From: Chaitanya Kulkarni <chaitanya.kulkarni@wdc.com>
To: hch@lst.de, martin.petersen@oracle.com
Cc: darrick.wong@oracle.com, axboe@kernel.dk, tytso@mit.edu,
adilger.kernel@dilger.ca, ming.lei@redhat.com,
jthumshirn@suse.de, minwoo.im.dev@gmail.com,
chaitanya.kulkarni@wdc.com, damien.lemoal@wdc.com,
andrea.parri@amarulasolutions.com, hare@suse.com, tj@kernel.org,
hannes@cmpxchg.org, khlebnikov@yandex-team.ru,
ajay.joshi@wdc.com, bvanassche@acm.org, arnd@arndb.de,
houtao1@huawei.com, asml.silence@gmail.com, ktkhai@virtuozzo.com,
linux-block@vger.kernel.org, linux-ext4@vger.kernel.org
Subject: [PATCH V2 4/4] ext4: Notify block device about alloc-assigned blk
Date: Mon, 6 Apr 2020 15:21:48 -0700 [thread overview]
Message-ID: <20200406222148.28365-5-chaitanya.kulkarni@wdc.com> (raw)
In-Reply-To: <20200406222148.28365-1-chaitanya.kulkarni@wdc.com>
From: Kirill Tkhai <ktkhai@virtuozzo.com>
Call sb_issue_allocate() after extent range was allocated on user
request. Hopeful, this helps block device to maintain its internals in
the best way, if this is appliable.
Signed-off-by: Kirill Tkhai <ktkhai@virtuozzo.com>
Signed-off-by: Chaitanya Kulkarni <chaitanya.kulkarni@wdc.com>
---
fs/ext4/ext4.h | 2 ++
fs/ext4/extents.c | 12 +++++++++++-
2 files changed, 13 insertions(+), 1 deletion(-)
diff --git a/fs/ext4/ext4.h b/fs/ext4/ext4.h
index 61b37a052052..0d0fa9904147 100644
--- a/fs/ext4/ext4.h
+++ b/fs/ext4/ext4.h
@@ -622,6 +622,8 @@ enum {
* allows jbd2 to avoid submitting data before commit. */
#define EXT4_GET_BLOCKS_IO_SUBMIT 0x0400
+#define EXT4_GET_BLOCKS_SUBMIT_ALLOC 0x0800
+
/*
* The bit position of these flags must not overlap with any of the
* EXT4_GET_BLOCKS_*. They are used by ext4_find_extent(),
diff --git a/fs/ext4/extents.c b/fs/ext4/extents.c
index 954013d6076b..37a60e190349 100644
--- a/fs/ext4/extents.c
+++ b/fs/ext4/extents.c
@@ -4449,6 +4449,14 @@ int ext4_ext_map_blocks(handle_t *handle, struct inode *inode,
ar.len = allocated;
got_allocated_blocks:
+ if ((flags & EXT4_GET_BLOCKS_SUBMIT_ALLOC) &&
+ inode->i_fop->fallocate) {
+ err = sb_issue_allocate(inode->i_sb, newblock,
+ EXT4_C2B(sbi, allocated_clusters), GFP_NOFS);
+ if (err)
+ goto free_on_err;
+ }
+
/* try to insert new extent into found leaf and return */
ext4_ext_store_pblock(&newex, newblock + offset);
newex.ee_len = cpu_to_le16(ar.len);
@@ -4466,6 +4474,7 @@ int ext4_ext_map_blocks(handle_t *handle, struct inode *inode,
err = ext4_ext_insert_extent(handle, inode, &path,
&newex, flags);
+free_on_err:
if (err && free_on_err) {
int fb_flags = flags & EXT4_GET_BLOCKS_DELALLOC_RESERVE ?
EXT4_FREE_BLOCKS_NO_QUOT_UPDATE : 0;
@@ -4733,7 +4742,8 @@ static long ext4_zero_range(struct file *file, loff_t offset,
goto out_mutex;
}
- flags = EXT4_GET_BLOCKS_CREATE_UNWRIT_EXT;
+ flags = EXT4_GET_BLOCKS_CREATE_UNWRIT_EXT |
+ EXT4_GET_BLOCKS_SUBMIT_ALLOC;
if (mode & FALLOC_FL_KEEP_SIZE)
flags |= EXT4_GET_BLOCKS_KEEP_SIZE;
--
2.22.0
prev parent reply other threads:[~2020-04-06 23:27 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-06 22:21 [PATCH V2 0/4] block: Add support for REQ_OP_ALLOCATE Chaitanya Kulkarni
2020-04-06 22:21 ` [PATCH V2 1/4] block: create payloadless issue bio helper Chaitanya Kulkarni
2020-04-06 22:21 ` [PATCH V2 2/4] block: Add support for REQ_OP_ALLOCATE Chaitanya Kulkarni
2020-04-06 22:21 ` [PATCH V2 3/4] loop: Forward REQ_OP_ALLOCATE into fallocate(0) Chaitanya Kulkarni
2020-04-06 22:21 ` Chaitanya Kulkarni [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200406222148.28365-5-chaitanya.kulkarni@wdc.com \
--to=chaitanya.kulkarni@wdc.com \
--cc=adilger.kernel@dilger.ca \
--cc=ajay.joshi@wdc.com \
--cc=andrea.parri@amarulasolutions.com \
--cc=arnd@arndb.de \
--cc=asml.silence@gmail.com \
--cc=axboe@kernel.dk \
--cc=bvanassche@acm.org \
--cc=damien.lemoal@wdc.com \
--cc=darrick.wong@oracle.com \
--cc=hannes@cmpxchg.org \
--cc=hare@suse.com \
--cc=hch@lst.de \
--cc=houtao1@huawei.com \
--cc=jthumshirn@suse.de \
--cc=khlebnikov@yandex-team.ru \
--cc=ktkhai@virtuozzo.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-ext4@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=ming.lei@redhat.com \
--cc=minwoo.im.dev@gmail.com \
--cc=tj@kernel.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).