From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A375CC2BA1A for ; Fri, 24 Apr 2020 10:35:47 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 894032071E for ; Fri, 24 Apr 2020 10:35:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726699AbgDXKfr (ORCPT ); Fri, 24 Apr 2020 06:35:47 -0400 Received: from verein.lst.de ([213.95.11.211]:34291 "EHLO verein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726667AbgDXKfq (ORCPT ); Fri, 24 Apr 2020 06:35:46 -0400 Received: by verein.lst.de (Postfix, from userid 2407) id 6A70B68CEE; Fri, 24 Apr 2020 12:35:43 +0200 (CEST) Date: Fri, 24 Apr 2020 12:35:43 +0200 From: Christoph Hellwig To: Ming Lei Cc: Jens Axboe , linux-block@vger.kernel.org, John Garry , Bart Van Assche , Hannes Reinecke , Christoph Hellwig , Thomas Gleixner , Mike Snitzer , dm-devel@redhat.com Subject: Re: [PATCH V8 02/11] block: add helper for copying request Message-ID: <20200424103543.GB28156@lst.de> References: <20200424102351.475641-1-ming.lei@redhat.com> <20200424102351.475641-3-ming.lei@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200424102351.475641-3-ming.lei@redhat.com> User-Agent: Mutt/1.5.17 (2007-11-01) Sender: linux-block-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org On Fri, Apr 24, 2020 at 06:23:42PM +0800, Ming Lei wrote: > Add one new helper of blk_rq_copy_request() to copy request, and the helper > will be used in this patch for re-submitting request, so make it as a block > layer internal helper. Looks good, Reviewed-by: Christoph Hellwig