From: Christoph Hellwig <hch@infradead.org>
To: Jan Kara <jack@suse.cz>
Cc: Jens Axboe <axboe@kernel.dk>, linux-block@vger.kernel.org
Subject: Re: [PATCH 0/3] Fix blkparse and iowatcher for kernels >= 4.14
Date: Wed, 6 May 2020 07:42:51 -0700 [thread overview]
Message-ID: <20200506144251.GA7564@infradead.org> (raw)
In-Reply-To: <20200506133933.4773-1-jack@suse.cz>
On Wed, May 06, 2020 at 03:39:30PM +0200, Jan Kara wrote:
> I was investigating a performance issue with BFQ IO scheduler and I was
> pondering why I'm not seeing informational messages from BFQ. After quite
> some debugging I have found out that commit 35fe6d763229 "block: use
> standard blktrace API to output cgroup info for debug notes" broke standard
> blktrace API - namely the informational messages logged by bfq_log_bfqq()
> are no longer displayed by blkparse(8) tool. This is because these messages
> have now __BLK_TA_CGROUP bit set and that breaks flags checking in
> blkparse(1) and iowatcher(1). This series fixes both tools to be able to
> cope with events with __BLK_TA_CGROUP flag set.
I'd much rather revert a kernel change that breaks frequently used
userspace.
next prev parent reply other threads:[~2020-05-06 14:42 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-06 13:39 [PATCH 0/3] Fix blkparse and iowatcher for kernels >= 4.14 Jan Kara
2020-05-06 13:39 ` [PATCH 1/3] blkparse: Handle cgroup information Jan Kara
2020-05-06 13:39 ` [PATCH 2/3] iowatcher: Use blktrace_api.h Jan Kara
2020-05-06 13:39 ` [PATCH 3/3] iowatcher: Handle cgroup information Jan Kara
2020-05-06 13:50 ` [PATCH 0/3] Fix blkparse and iowatcher for kernels >= 4.14 Paolo Valente
2020-05-06 14:12 ` Jan Kara
2020-05-06 14:42 ` Christoph Hellwig [this message]
2020-05-07 9:49 ` Jan Kara
2020-05-20 13:38 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200506144251.GA7564@infradead.org \
--to=hch@infradead.org \
--cc=axboe@kernel.dk \
--cc=jack@suse.cz \
--cc=linux-block@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).