From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.9 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A2F09C38A24 for ; Thu, 7 May 2020 07:44:44 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 804FB2080D for ; Thu, 7 May 2020 07:44:44 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="MW3uq3kM" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725834AbgEGHon (ORCPT ); Thu, 7 May 2020 03:44:43 -0400 Received: from us-smtp-1.mimecast.com ([205.139.110.61]:47861 "EHLO us-smtp-delivery-1.mimecast.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1725809AbgEGHon (ORCPT ); Thu, 7 May 2020 03:44:43 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1588837482; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=h6uswedAMjpbqecNSfTjRCenxs9Rh0/ygb45+I7a8eQ=; b=MW3uq3kMmhv9AWEUcCGr6BBHicAFhCoDaqaFuBOaHrsz9NuHEe5PYhkNVABEZYQzoBACq3 DmDlddgEvnmXwQfJILei0ZV9FI34wXrboCoy5omstrft2XAiri5zxX7lJ9gVFcfCTMwO7/ TFnzgRVlSu3nT5LZv6XZ+iMYv/OnHSc= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-278-9dXyWPYcOxCf54YDKpZcrw-1; Thu, 07 May 2020 03:44:40 -0400 X-MC-Unique: 9dXyWPYcOxCf54YDKpZcrw-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id D017C1895A2A; Thu, 7 May 2020 07:44:38 +0000 (UTC) Received: from T590 (ovpn-8-38.pek2.redhat.com [10.72.8.38]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 60B945D9C5; Thu, 7 May 2020 07:44:27 +0000 (UTC) Date: Thu, 7 May 2020 15:44:23 +0800 From: Ming Lei To: Christoph Hellwig Cc: axboe@kernel.dk, yuyufen@huawei.com, tj@kernel.org, jack@suse.cz, bvanassche@acm.org, tytso@mit.edu, hdegoede@redhat.com, gregkh@linuxfoundation.org, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: bdi: fix use-after-free for dev_name(bdi->dev) v3 (resend) Message-ID: <20200507074423.GA1285373@T590> References: <20200504124801.2832087-1-hch@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200504124801.2832087-1-hch@lst.de> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 Sender: linux-block-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org On Mon, May 04, 2020 at 02:47:52PM +0200, Christoph Hellwig wrote: > Hi Jens, > > can you pick up this series? > > the first three patches are my take on the proposal from Yufen Yu > to fix the use after free of the device name of the bdi device. > > The rest is vaguely related cleanups. > > Changes since v2: > - switch vboxsf to a shorter bdi name > > Changes since v1: > - use a static dev_name buffer inside struct backing_dev_info > Looks fine: Reviewed-by: Ming Lei -- Ming