From: Christoph Hellwig <hch@lst.de>
To: axboe@kernel.dk
Cc: linux-block@vger.kernel.org
Subject: [PATCH 2/4] block: remove a pointless queue enter pair in blk_mq_alloc_request
Date: Wed, 13 May 2020 13:04:17 +0200 [thread overview]
Message-ID: <20200513110419.2362556-3-hch@lst.de> (raw)
In-Reply-To: <20200513110419.2362556-1-hch@lst.de>
No need for two queue references.
Signed-off-by: Christoph Hellwig <hch@lst.de>
---
block/blk-mq.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/block/blk-mq.c b/block/blk-mq.c
index 9865a36e6a6e3..a3491c1397501 100644
--- a/block/blk-mq.c
+++ b/block/blk-mq.c
@@ -404,10 +404,7 @@ struct request *blk_mq_alloc_request(struct request_queue *q, unsigned int op,
if (ret)
return ERR_PTR(ret);
- blk_queue_enter_live(q);
rq = blk_mq_get_request(q, NULL, &alloc_data);
- blk_queue_exit(q);
-
if (!rq) {
blk_queue_exit(q);
return ERR_PTR(-EWOULDBLOCK);
--
2.26.2
next prev parent reply other threads:[~2020-05-13 11:04 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-13 11:04 avoid a few q_usage_counter roundtrips Christoph Hellwig
2020-05-13 11:04 ` [PATCH 1/4] block: move the call to blk_queue_enter_live out of blk_mq_get_request Christoph Hellwig
2020-05-13 11:04 ` Christoph Hellwig [this message]
2020-05-13 11:04 ` [PATCH 3/4] block: remove a pointless queue enter pair in blk_mq_alloc_request_hctx Christoph Hellwig
2020-05-13 12:02 ` Johannes Thumshirn
2020-05-13 12:23 ` Christoph Hellwig
2020-05-13 11:04 ` [PATCH 4/4] block: allow blk_mq_make_request to consume the q_usage_counter reference Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200513110419.2362556-3-hch@lst.de \
--to=hch@lst.de \
--cc=axboe@kernel.dk \
--cc=linux-block@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).