From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D7D9FC433E0 for ; Sat, 16 May 2020 12:38:05 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C011920727 for ; Sat, 16 May 2020 12:38:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726233AbgEPMiF (ORCPT ); Sat, 16 May 2020 08:38:05 -0400 Received: from verein.lst.de ([213.95.11.211]:60417 "EHLO verein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726229AbgEPMiE (ORCPT ); Sat, 16 May 2020 08:38:04 -0400 Received: by verein.lst.de (Postfix, from userid 2407) id AE09368B05; Sat, 16 May 2020 14:38:01 +0200 (CEST) Date: Sat, 16 May 2020 14:38:01 +0200 From: Christoph Hellwig To: Coly Li Cc: linux-block@vger.kernel.org, damien.lemoal@wdc.com, hare@suse.com, hch@lst.de, axboe@kernel.dk, linux-bcache@vger.kernel.org, kbusch@kernel.org, Hannes Reinecke , Jens Axboe , Johannes Thumshirn , Shaun Tancheff Subject: Re: [RFC PATCH v2 1/4] block: change REQ_OP_ZONE_RESET from 6 to 13 Message-ID: <20200516123801.GB13448@lst.de> References: <20200516035434.82809-1-colyli@suse.de> <20200516035434.82809-2-colyli@suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200516035434.82809-2-colyli@suse.de> User-Agent: Mutt/1.5.17 (2007-11-01) Sender: linux-block-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org On Sat, May 16, 2020 at 11:54:31AM +0800, Coly Li wrote: > For a zoned device, e.g. host managed SMR hard drive, REQ_OP_ZONE_RESET > is to reset the LBA of a zone's write pointer back to the start LBA of > this zone. After the write point is reset, all previously stored data > in this zone is invalid and unaccessible anymore. Therefore, this op > code changes on disk data, belongs to a WRITE request op code. > > Current REQ_OP_ZONE_RESET is defined as number 6, but the convention of > the op code is, READ requests are even numbers, and WRITE requests are > odd numbers. See how op_is_write defined, The convention is all about data transfer, and zone reset does not transfer any data.