From: Ming Lei <ming.lei@redhat.com>
To: Jens Axboe <axboe@kernel.dk>,
linux-block@vger.kernel.org, linux-nvme@lists.infradead.org,
Christoph Hellwig <hch@lst.de>
Cc: Alan Adamson <alan.adamson@oracle.com>
Subject: Re: [PATCH 0/3] blk-mq/nvme: improve nvme-pci reset handler
Date: Tue, 26 May 2020 10:55:27 +0800 [thread overview]
Message-ID: <20200526025527.GA865019@T590> (raw)
In-Reply-To: <20200520115655.729705-1-ming.lei@redhat.com>
On Wed, May 20, 2020 at 07:56:52PM +0800, Ming Lei wrote:
> Hi,
>
> For nvme-pci, after controller is recovered, in-flight IOs are waited
> before updating nr hw queues. If new controller error happens during
> this period, nvme-pci driver deletes the controller and fails in-flight
> IO. This way is too violent, and not friendly from user viewpoint.
>
> Add APIs for checking if queue is frozen, and replace nvme_wait_freeze
> in nvme-pci reset handler with checking if all ns queues are frozen &
> controller disabled. Then a fresh new reset can be scheduled for
> handling new controller error during waiting for in-flight IO completion.
>
> So deleting controller & failing IOs can be avoided in this situation.
>
> Without this patches, when fail io timeout injection is run, the
> controller can be removed very quickly. With this patch, no controller
> removing can be observed, and controller can recover to normal state
> after stopping to inject io timeout failure.
>
> Ming Lei (3):
> blk-mq: add API of blk_mq_queue_frozen
> nvme: add nvme_frozen
> nvme-pci: make nvme reset more reliable
>
> block/blk-mq.c | 6 ++++++
> drivers/nvme/host/core.c | 14 ++++++++++++++
> drivers/nvme/host/nvme.h | 1 +
> drivers/nvme/host/pci.c | 37 ++++++++++++++++++++++++++++++-------
> include/linux/blk-mq.h | 1 +
> 5 files changed, 52 insertions(+), 7 deletions(-)
>
> --
> 2.25.2
>
Hello Guys,
Ping...
Thanks,
Ming
next prev parent reply other threads:[~2020-05-26 2:55 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-20 11:56 [PATCH 0/3] blk-mq/nvme: improve nvme-pci reset handler Ming Lei
2020-05-20 11:56 ` [PATCH 1/3] blk-mq: add API of blk_mq_queue_frozen Ming Lei
2020-05-20 11:56 ` [PATCH 2/3] nvme: add nvme_frozen Ming Lei
2020-05-20 11:56 ` [PATCH 3/3] nvme-pci: make nvme reset more reliable Ming Lei
2020-05-20 17:10 ` Dongli Zhang
2020-05-20 17:27 ` Dongli Zhang
2020-05-20 17:52 ` Keith Busch
2020-05-21 2:33 ` Ming Lei
2020-05-26 5:01 ` Dongli Zhang
2020-05-26 7:12 ` Ming Lei
2020-05-26 2:55 ` Ming Lei [this message]
2020-05-27 18:09 ` [PATCH 0/3] blk-mq/nvme: improve nvme-pci reset handler Alan Adamson
2020-05-27 18:52 ` Keith Busch
2020-05-28 1:36 ` Ming Lei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200526025527.GA865019@T590 \
--to=ming.lei@redhat.com \
--cc=alan.adamson@oracle.com \
--cc=axboe@kernel.dk \
--cc=hch@lst.de \
--cc=linux-block@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).