From: Christoph Hellwig <hch@lst.de>
To: Bart Van Assche <bvanassche@acm.org>
Cc: Christoph Hellwig <hch@lst.de>,
linux-block@vger.kernel.org, John Garry <john.garry@huawei.com>,
Hannes Reinecke <hare@suse.com>,
Thomas Gleixner <tglx@linutronix.de>,
Ming Lei <ming.lei@redhat.com>
Subject: Re: [PATCH 5/6] blk-mq: add blk_mq_all_tag_iter
Date: Wed, 27 May 2020 08:05:35 +0200 [thread overview]
Message-ID: <20200527060535.GA17957@lst.de> (raw)
In-Reply-To: <a9b8686b-e3f8-bbd9-7dc8-fc55bd9b7f14@acm.org>
On Wed, May 20, 2020 at 01:24:02PM -0700, Bart Van Assche wrote:
> Adding /*reserved=*/ and /*iterate_all=*/ comments in front of the
> boolean arguments would make this code easier to read.
Actually, flags values would be much more understandable, and allow to
consolidate more code. I've switched the implementation over to that.
next prev parent reply other threads:[~2020-05-27 6:05 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-20 17:06 blk-mq: improvement CPU hotplug (simplified version) v3 Christoph Hellwig
2020-05-20 17:06 ` [PATCH 1/6] blk-mq: remove the bio argument to ->prepare_request Christoph Hellwig
2020-05-20 18:16 ` Bart Van Assche
2020-05-22 9:11 ` Hannes Reinecke
2020-05-20 17:06 ` [PATCH 2/6] blk-mq: simplify the blk_mq_get_request calling convention Christoph Hellwig
2020-05-20 18:22 ` Bart Van Assche
2020-05-22 9:13 ` Hannes Reinecke
2020-05-20 17:06 ` [PATCH 3/6] blk-mq: move more request initialization to blk_mq_rq_ctx_init Christoph Hellwig
2020-05-20 20:10 ` Bart Van Assche
2020-05-20 17:06 ` [PATCH 4/6] blk-mq: open code __blk_mq_alloc_request in blk_mq_alloc_request_hctx Christoph Hellwig
2020-05-22 9:17 ` Hannes Reinecke
2020-05-20 17:06 ` [PATCH 5/6] blk-mq: add blk_mq_all_tag_iter Christoph Hellwig
2020-05-20 20:24 ` Bart Van Assche
2020-05-27 6:05 ` Christoph Hellwig [this message]
2020-05-22 9:18 ` Hannes Reinecke
2020-05-20 17:06 ` [PATCH 6/6] blk-mq: drain I/O when all CPUs in a hctx are offline Christoph Hellwig
2020-05-22 9:25 ` Hannes Reinecke
2020-05-25 9:20 ` Ming Lei
2020-05-20 21:46 ` blk-mq: improvement CPU hotplug (simplified version) v3 Bart Van Assche
2020-05-21 2:57 ` Ming Lei
2020-05-21 3:50 ` Bart Van Assche
2020-05-21 4:33 ` Ming Lei
2020-05-21 19:15 ` Bart Van Assche
2020-05-22 2:39 ` Ming Lei
2020-05-22 14:47 ` Keith Busch
2020-05-23 3:05 ` Ming Lei
2020-05-23 15:19 ` Bart Van Assche
2020-05-25 4:09 ` Ming Lei
2020-05-25 15:32 ` Bart Van Assche
2020-05-25 16:38 ` Keith Busch
2020-05-26 0:37 ` Ming Lei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200527060535.GA17957@lst.de \
--to=hch@lst.de \
--cc=bvanassche@acm.org \
--cc=hare@suse.com \
--cc=john.garry@huawei.com \
--cc=linux-block@vger.kernel.org \
--cc=ming.lei@redhat.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).