From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.4 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 76F0EC433E0 for ; Thu, 28 May 2020 16:41:55 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 444F52084C for ; Thu, 28 May 2020 16:41:55 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=chrisdown.name header.i=@chrisdown.name header.b="dZ/4oQHk" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2405119AbgE1Qlx (ORCPT ); Thu, 28 May 2020 12:41:53 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34544 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2405043AbgE1Qlw (ORCPT ); Thu, 28 May 2020 12:41:52 -0400 Received: from mail-wr1-x443.google.com (mail-wr1-x443.google.com [IPv6:2a00:1450:4864:20::443]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8B5D2C08C5C7 for ; Thu, 28 May 2020 09:41:50 -0700 (PDT) Received: by mail-wr1-x443.google.com with SMTP id l11so28799173wru.0 for ; Thu, 28 May 2020 09:41:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chrisdown.name; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=Pvf7qBFEHIiAL/UpG9xM7Gf8VhxhCVBHlvWj3inRLaM=; b=dZ/4oQHkI3iFVl6Q4XDatBaCWT8WDKIy43ty6iL5UZV9y8w2Mwc2zwtaHwr00vostz c8tS4BvevPCZZt4NdTss07rL4pzKusdIZLJ1Zm9Z3FuwwbTD2hfas29vKN5+7iQ8CBt4 fMhXjwXce9iKSnXnt3Jr4qQvtVDCYiR2OFQFw= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=Pvf7qBFEHIiAL/UpG9xM7Gf8VhxhCVBHlvWj3inRLaM=; b=tB2LzkfZiqDHo2ci+fYd6b+mnNq7/Zw3x4h3Y4ACP4FGPm+0oXgXg9N1zA62sixRuS jEN2XiEWAKYKx+ue/pt3UAiU3Ne8HqTdTK4DRQpfJJk0kMG+Rq5Xib9qdRmT8JtrdyWd 1gjLcIlNByYEh058HBRkBTqaFBw4/TJ9D02ZBZN0kuA/1LhPPudSchSbWFlDq8qPvTUj csAmotHZWw2MExepGbpcXywaXgRBVuxpxmomtRtYzmoyAJrRatVYbJCunZKuHzM3JqrG 6teChQXBNTX1YiD+YGfrm1W918KjtaOGFQXtZkxPzHqXXlEtOc8iY6RhPpwfhrJJdRpP SOFA== X-Gm-Message-State: AOAM531yrZ7I3beQ5Q3fu6KijBpvDWxg6nnvj5KmT1efY+/yoysStR/S ynGrvw+vbU7Vu91MiBetQ0K+BQ== X-Google-Smtp-Source: ABdhPJx43EFGY79zZc9WHOq4nlucrHubXscZYsQcdCStmKVBziBJ4zuFJn23rjI3pradupO/1Tk0Ig== X-Received: by 2002:adf:ff82:: with SMTP id j2mr4130619wrr.375.1590684083033; Thu, 28 May 2020 09:41:23 -0700 (PDT) Received: from localhost ([2620:10d:c093:400::5:d125]) by smtp.gmail.com with ESMTPSA id y66sm6698899wmy.24.2020.05.28.09.41.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 28 May 2020 09:41:22 -0700 (PDT) Date: Thu, 28 May 2020 17:41:21 +0100 From: Chris Down To: Naresh Kamboju Cc: Michal Hocko , Yafang Shao , Anders Roxell , "Linux F2FS DEV, Mailing List" , linux-ext4 , linux-block , Andrew Morton , open list , Linux-Next Mailing List , linux-mm , Arnd Bergmann , Andreas Dilger , Jaegeuk Kim , Theodore Ts'o , Chao Yu , Hugh Dickins , Andrea Arcangeli , Matthew Wilcox , Chao Yu , lkft-triage@lists.linaro.org, Johannes Weiner , Roman Gushchin , Cgroups Subject: Re: mm: mkfs.ext4 invoked oom-killer on i386 - pagecache_get_page Message-ID: <20200528164121.GA839178@chrisdown.name> References: <20200519084535.GG32497@dhcp22.suse.cz> <20200520190906.GA558281@chrisdown.name> <20200521095515.GK6462@dhcp22.suse.cz> <20200521163450.GV6462@dhcp22.suse.cz> <20200528150310.GG27484@dhcp22.suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.14.2 (2020-05-25) Sender: linux-block-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org Naresh Kamboju writes: >On Thu, 28 May 2020 at 20:33, Michal Hocko wrote: >> >> On Fri 22-05-20 02:23:09, Naresh Kamboju wrote: >> > My apology ! >> > As per the test results history this problem started happening from >> > Bad : next-20200430 (still reproducible on next-20200519) >> > Good : next-20200429 >> > >> > The git tree / tag used for testing is from linux next-20200430 tag and reverted >> > following three patches and oom-killer problem fixed. >> > >> > Revert "mm, memcg: avoid stale protection values when cgroup is above >> > protection" >> > Revert "mm, memcg: decouple e{low,min} state mutations from protectinn checks" >> > Revert "mm-memcg-decouple-elowmin-state-mutations-from-protection-checks-fix" >> >> The discussion has fragmented and I got lost TBH. >> In http://lkml.kernel.org/r/CA+G9fYuDWGZx50UpD+WcsDeHX9vi3hpksvBAWbMgRZadb0Pkww@mail.gmail.com >> you have said that none of the added tracing output has triggered. Does >> this still hold? Because I still have a hard time to understand how >> those three patches could have the observed effects. > >On the other email thread [1] this issue is concluded. > >Yafang wrote on May 22 2020, > >Regarding the root cause, my guess is it makes a similar mistake that >I tried to fix in the previous patch that the direct reclaimer read a >stale protection value. But I don't think it is worth to add another >fix. The best way is to revert this commit. This isn't a conclusion, just a guess (and one I think is unlikely). For this to reliably happen, it implies that the same race happens the same way each time.