From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 88546C433E0 for ; Thu, 18 Jun 2020 12:37:53 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 54AE12070A for ; Thu, 18 Jun 2020 12:37:53 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=chrisdown.name header.i=@chrisdown.name header.b="Vba3/YBp" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729803AbgFRMhs (ORCPT ); Thu, 18 Jun 2020 08:37:48 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37878 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729409AbgFRMhq (ORCPT ); Thu, 18 Jun 2020 08:37:46 -0400 Received: from mail-wm1-x341.google.com (mail-wm1-x341.google.com [IPv6:2a00:1450:4864:20::341]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5A7B4C0613EE for ; Thu, 18 Jun 2020 05:37:46 -0700 (PDT) Received: by mail-wm1-x341.google.com with SMTP id t194so5472644wmt.4 for ; Thu, 18 Jun 2020 05:37:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chrisdown.name; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=OgZomFoj/7toYCBCKWRo7nq/kYdKAWeXt05LtEajY3k=; b=Vba3/YBp135F4zjZnb2RedWXF2lwu1lFFL34CLaNpxPjPTPlt0UR472eYi5S4YZ1Wx Z0rDK+6Hs9d3o0cUOdxwi2SS36Jq5bWlnav7DNmZNgJpcMQ+D8caGFIGg/ORh0SmmPxl k69/g/gWD8TgMCYkGiY2Wz/GRty0LMQ/SrbXk= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=OgZomFoj/7toYCBCKWRo7nq/kYdKAWeXt05LtEajY3k=; b=M8HJaQogGJLV/HSDXX7iAwu+1uX3phQpBqpqm4dAuE7qZgylApkQFaMmEMC9txiWcN yQGKAUIbDOllJs0kna4XI7iGKkjbM8eZz5STonYU+UDqPlmvprLTsOJOVxAl4Ko51ewb iPCHD+v/0Ye4nneJcJ51E/STFJVGNGLQkej5bHpzNkHbQw/RL1JGzki82Z26HkcxbV+8 IYdc3mbTNZmAdnj4s6jIlOyr703uTg4CM1kvHEA0H+nj58JVqvyta+WJBJNuBztaqXzL gzXsjODyB3zwDYEf4KgXw3ig7oB2JVN9cMwRKE5VTH+zuriXGkRvekw5Gney2bRK1tEb QgVQ== X-Gm-Message-State: AOAM532dxzRuNhfa7eXTh3ndemgEtICo/r1l8gfHK1zPnBC3NdC4MsUb fgPLAI2A08EEqpQNF49Hr9FU5Q== X-Google-Smtp-Source: ABdhPJzFoWSkp2MqAS0xx92RSUWbWQ0U7Z92SQ/MTtOdoN5z3gnxoKRC/r81z8qHIYMjhulYtZARyw== X-Received: by 2002:a1c:4143:: with SMTP id o64mr3734793wma.157.1592483864725; Thu, 18 Jun 2020 05:37:44 -0700 (PDT) Received: from localhost ([2a01:4b00:8432:8a00:63de:dd93:20be:f460]) by smtp.gmail.com with ESMTPSA id t82sm2586962wmg.10.2020.06.18.05.37.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 18 Jun 2020 05:37:43 -0700 (PDT) Date: Thu, 18 Jun 2020 13:37:43 +0100 From: Chris Down To: Yafang Shao Cc: Naresh Kamboju , Michal Hocko , Anders Roxell , "Linux F2FS DEV, Mailing List" , linux-ext4 , linux-block , Andrew Morton , open list , Linux-Next Mailing List , linux-mm , Arnd Bergmann , Andreas Dilger , Jaegeuk Kim , Theodore Ts'o , Chao Yu , Hugh Dickins , Andrea Arcangeli , Matthew Wilcox , Chao Yu , lkft-triage@lists.linaro.org, Johannes Weiner , Roman Gushchin , Cgroups Subject: Re: mm: mkfs.ext4 invoked oom-killer on i386 - pagecache_get_page Message-ID: <20200618123743.GA694719@chrisdown.name> References: <20200521095515.GK6462@dhcp22.suse.cz> <20200521163450.GV6462@dhcp22.suse.cz> <20200617135758.GA548179@chrisdown.name> <20200617141155.GQ9499@dhcp22.suse.cz> <20200617160624.GS9499@dhcp22.suse.cz> <20200617210935.GA578452@chrisdown.name> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.14.3 (2020-06-14) Sender: linux-block-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org Yafang Shao writes: >On Thu, Jun 18, 2020 at 5:09 AM Chris Down wrote: >> >> Naresh Kamboju writes: >> >After this patch applied the reported issue got fixed. >> >> Great! Thank you Naresh and Michal for helping to get to the bottom of this :-) >> >> I'll send out a new version tomorrow with the fixes applied and both of you >> credited in the changelog for the detection and fix. > >As we have already found that the usage around memory.{emin, elow} has >many limitations, I think memory.{emin, elow} should be used for >memcg-tree internally only, that means they can only be used to >calculate the protection of a memcg in a specified memcg-tree but >should not be exposed to other MM parts. I agree that the current semantics are mentally taxing and we should generally avoid exposing the implementation details outside of memcg where possible. Do you have a suggested rework? :-)