From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 71E8EC433E0 for ; Wed, 24 Jun 2020 18:40:20 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 525F720767 for ; Wed, 24 Jun 2020 18:40:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1593024020; bh=1Ayf49uhgE7vr8uKG6gfOWWzcGP7/yzm4SH4WSWuvA8=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=rSny7VJN1HegZz4Zl2UpTEocF2S+U8k6B+CB+eteiNuCJk/lJJHG1zmqQJrTHS6Fo 9CTS77nj56JKZG7ojhgKPrNewTQ/92SNbldPuk36cw0pqddd+GsaEyxmSivaGjAQwz xYYgX6Yi8ZWmnOltmOS7wxRql6wHWUj/kX38qIcE= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2405808AbgFXSkT (ORCPT ); Wed, 24 Jun 2020 14:40:19 -0400 Received: from mail.kernel.org ([198.145.29.99]:46930 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2405581AbgFXSkT (ORCPT ); Wed, 24 Jun 2020 14:40:19 -0400 Received: from dhcp-10-100-145-180.wdl.wdc.com (unknown [199.255.45.60]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 095E4206A5; Wed, 24 Jun 2020 18:40:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1593024018; bh=1Ayf49uhgE7vr8uKG6gfOWWzcGP7/yzm4SH4WSWuvA8=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=cPtqh+bm8K2onckaiVIEGIhxyVjyv963gJ4NMXh4trAq4tva2CdHrLq3ceQZ2G3eB PN6HcPmRuwLPD2ui2rZY/Gdyz/FIe+I6nLz19EIUfhiCCSjCUawdUCgaLiB4EJ+FgK WY2wrva8ZzMTTtZrPPKxAIxsVR9gV8x3LWEqsiHg= Date: Wed, 24 Jun 2020 11:40:16 -0700 From: Keith Busch To: Sagi Grimberg Cc: Niklas Cassel , "linux-nvme@lists.infradead.org" , "hch@lst.de" , "linux-block@vger.kernel.org" , "axboe@kernel.dk" , Javier =?iso-8859-1?Q?Gonz=E1lez?= , "Martin K . Petersen" , Johannes Thumshirn , Matias Bjorling , Daniel Wagner Subject: Re: [PATCHv3 3/5] nvme: implement I/O Command Sets Command Set support Message-ID: <20200624184016.GF1291930@dhcp-10-100-145-180.wdl.wdc.com> References: <20200622162530.1287650-4-kbusch@kernel.org> <69e8e88c-097b-368d-58f4-85d11110386d@grimberg.me> <20200623112551.GB117742@localhost.localdomain> <20200623221012.GA1291643@dhcp-10-100-145-180.wdl.wdc.com> <20200624172509.GD1291930@dhcp-10-100-145-180.wdl.wdc.com> <20200624180323.GE1291930@dhcp-10-100-145-180.wdl.wdc.com> <1ddbf614-f5a7-a265-b1a2-7c5ed0922f18@grimberg.me> <76966a48-0588-3f3c-0ec1-842cd2ac413d@grimberg.me> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <76966a48-0588-3f3c-0ec1-842cd2ac413d@grimberg.me> Sender: linux-block-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org On Wed, Jun 24, 2020 at 11:33:25AM -0700, Sagi Grimberg wrote: > > > If the controller does not support the CNS value, it may return Invalid > > > Field with DNR set. That error currently gets propogated back to > > > nvme_init_ns_head(), which then abandons the namespace. Just as the code > > > coments say, we had been historically been clearing such errors because > > > we have other ways to identify the namespace, but now we're not clearing > > > that error. > > > > I don't understand what you are saying Keith. > > > > My comment was for this block: > > -- > >     if (!status && nvme_multi_css(ctrl) && !csi_seen) { > >         dev_warn(ctrl->device, "Command set not reported for nsid:%d\n", > >              nsid); > >         status = -EINVAL; > >     } > > -- > > > > I was saying that !status doesn't necessarily mean success, but it can > > also mean that its an retry-able error status (due to transport or > > controller). If we see a retry-able error we should still clear the > > status so we don't abandon the namespace. > > > > This for example would achieve that: We're not talking about the same thing. I am only talking about what introduced the DNR check, from commit 59c7c3caaaf87. I know you added it because you want to abort comparing identifiers on a rescan when retrieving the identifiers failed. That's fine, but I am saying this fails namespace creation in the first place for some types of devices that used to succeed.