linux-block.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Ming Lei <ming.lei@redhat.com>
To: Sagi Grimberg <sagi@grimberg.me>
Cc: Jens Axboe <axboe@kernel.dk>,
	linux-block@vger.kernel.org,
	Damien Le Moal <Damien.LeMoal@wdc.com>,
	Baolin Wang <baolin.wang7@gmail.com>,
	Christoph Hellwig <hch@infradead.org>
Subject: Re: [PATCH V5 0/6] blk-mq: support batching dispatch from scheduler
Date: Thu, 25 Jun 2020 06:58:55 +0800	[thread overview]
Message-ID: <20200624225855.GA1045898@T590> (raw)
In-Reply-To: <4c5d8c1b-2b5a-1bee-b5eb-5f4b7336b979@grimberg.me>

On Wed, Jun 24, 2020 at 02:17:28PM -0700, Sagi Grimberg wrote:
> 
> > Hi Jens,
> > 
> > More and more drivers want to get batching requests queued from
> > block layer, such as mmc[1], and tcp based storage drivers[2]. Also
> > current in-tree users have virtio-scsi, virtio-blk and nvme.
> > 
> > For none, we already support batching dispatch.
> > 
> > But for io scheduler, every time we just take one request from scheduler
> > and pass the single request to blk_mq_dispatch_rq_list(). This way makes
> > batching dispatch not possible when io scheduler is applied. One reason
> > is that we don't want to hurt sequential IO performance, becasue IO
> > merge chance is reduced if more requests are dequeued from scheduler
> > queue.
> > 
> > Tries to start the support by dequeuing more requests from scheduler
> > if budget is enough and device isn't busy.
> > 
> > Simple fio test over virtio-scsi shows IO can get improved by 5~10%.
> > 
> > Baolin has tested previous versions and found performance on MMC can be improved.
> > 
> > Patch 1 ~ 4 are improvement and cleanup, which can't applied without
> > supporting batching dispatch.
> > 
> > Patch 5 ~ 6 starts to support batching dispatch from scheduler.
> > 
> > 
> > 
> > [1] https://lore.kernel.org/linux-block/20200512075501.GF1531898@T590/#r
> > [2] https://lore.kernel.org/linux-block/fe6bd8b9-6ed9-b225-f80c-314746133722@grimberg.me/
> > 
> > V5:
> > 	- code style changes suggested by Damien
> > 
> > V4:
> > 	- fix releasing budgets and avoids IO hang(5/6)
> > 	- dispatch more batches if the device can accept more(6/6)
> > 	- verified by running more tests
> > 
> > V3:
> > 	- add reviewed-by tag
> > 	- fix one typo
> > 	- fix one budget leak issue in case that .queue_rq returned *_RESOURCE in 5/6
> > 
> > V2:
> > 	- remove 'got_budget' from blk_mq_dispatch_rq_list
> > 	- drop patch for getting driver tag & handling partial dispatch
> 
> Hey Ming,
> 
> What ever happened to this one?

Hi Sagi,

Looks the 1st patch can't be applied cleanly against for-5.9/block, I will send
V6 later.

thanks,
Ming


      reply	other threads:[~2020-06-24 22:59 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-03  9:43 [PATCH V5 0/6] blk-mq: support batching dispatch from scheduler Ming Lei
2020-06-03  9:43 ` [PATCH V5 1/6] blk-mq: pass request queue into get/put budget callback Ming Lei
2020-06-03  9:43 ` [PATCH V5 2/6] blk-mq: pass hctx to blk_mq_dispatch_rq_list Ming Lei
2020-06-03  9:43 ` [PATCH V5 3/6] blk-mq: move getting driver tag and budget into one helper Ming Lei
2020-06-03  9:43 ` [PATCH V5 4/6] blk-mq: remove dead check from blk_mq_dispatch_rq_list Ming Lei
2020-06-03  9:43 ` [PATCH V5 5/6] blk-mq: pass obtained budget count to blk_mq_dispatch_rq_list Ming Lei
2020-06-03  9:43 ` [PATCH V5 6/6] blk-mq: support batching dispatch in case of io scheduler Ming Lei
2020-06-24 21:17 ` [PATCH V5 0/6] blk-mq: support batching dispatch from scheduler Sagi Grimberg
2020-06-24 22:58   ` Ming Lei [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200624225855.GA1045898@T590 \
    --to=ming.lei@redhat.com \
    --cc=Damien.LeMoal@wdc.com \
    --cc=axboe@kernel.dk \
    --cc=baolin.wang7@gmail.com \
    --cc=hch@infradead.org \
    --cc=linux-block@vger.kernel.org \
    --cc=sagi@grimberg.me \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).