From: Steven Rostedt <rostedt@goodmis.org>
To: Chaitanya Kulkarni <chaitanya.kulkarni@wdc.com>
Cc: linux-block@vger.kernel.org, dm-devel@redhat.com, jack@suse.czi,
rdunlap@infradead.org, sagi@grimberg.me, mingo@redhat.com,
snitzer@redhat.com, agk@redhat.com, axboe@kernel.dk,
paolo.valente@linaro.org, ming.lei@redhat.com,
bvanassche@acm.org, fangguoju@gmail.com, colyli@suse.de,
hch@lst.de
Subject: Re: [PATCH 00/10] block: blktrace framework cleanup
Date: Mon, 29 Jun 2020 20:58:53 -0400 [thread overview]
Message-ID: <20200629205853.38628a63@oasis.local.home> (raw)
In-Reply-To: <20200629234314.10509-1-chaitanya.kulkarni@wdc.com>
On Mon, 29 Jun 2020 16:43:03 -0700
Chaitanya Kulkarni <chaitanya.kulkarni@wdc.com> wrote:
> Hi,
>
> There are many places where trace API accepts the struct request_queue*
> parameter which can be derived from other function parameters.
>
> This patch-series removes the struct request queue parameter from the
> blktrace framework and adjusts the tracepoints definition and usage
> along with the tracing API itself.
>
> Also with the queue parameter removed now we can merge some of the trace
> events with creating generic event class for bio based tarce events.
>
> Finally few of more cleanups to remove the trace_block_rq_insert()
> wrapper blk_mq_sched_request_inserted(), get rid of the extra parameter
> for trace_block_getrq, remove the blk_trace_request_get_cgid(),
> fix tracepoint comment header, and blk_fill_rwbs() related triggred
> cleanup.
>
> I've added patches after first cleanup as I scan the code for more
> cleanup. I think patch distribution can be better but it will be great
> to have some feedback as the amount of clenaup has grown bigger.
>
> Any comments are welcome.
>
> Regards,
> Chaitanya
>
> Chaitanya Kulkarni (11):
> block: blktrace framework cleanup
> block: rename block_bio_merge class to block_bio
> block: use block_bio event class for bio_queue
> block: use block_bio event class for bio_bounce
> block: get rid of the trace rq insert wrapper
> block: remove extra param for trace_block_getrq()
> block: get rid of blk_trace_request_get_cgid()
> block: fix the comments in the trace event block.h
> block: remove unsed param in blk_fill_rwbs()
> block: use block_bio class for getrq and sleeprq
> block: remove block_get_rq event class
From a tracing perspective:
Acked-by: Steven Rostedt (VMware) <rostedt@goodmis.org>
-- Steve
>
> block/bfq-iosched.c | 4 +-
> block/blk-core.c | 6 +-
> block/blk-merge.c | 4 +-
> block/blk-mq-sched.c | 6 -
> block/blk-mq-sched.h | 1 -
> block/blk-mq.c | 10 +-
> block/bounce.c | 2 +-
> block/kyber-iosched.c | 4 +-
> block/mq-deadline.c | 4 +-
> drivers/md/dm.c | 4 +-
> include/linux/blktrace_api.h | 2 +-
> include/trace/events/bcache.h | 10 +-
> include/trace/events/block.h | 226 +++++++++++-----------------------
> kernel/trace/blktrace.c | 129 +++++++++----------
> 14 files changed, 161 insertions(+), 251 deletions(-)
>
prev parent reply other threads:[~2020-06-30 0:58 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-29 23:43 [PATCH 00/10] block: blktrace framework cleanup Chaitanya Kulkarni
2020-06-29 23:43 ` [PATCH 01/11] " Chaitanya Kulkarni
2020-06-30 5:10 ` Christoph Hellwig
2020-07-01 4:32 ` Chaitanya Kulkarni
2020-06-29 23:43 ` [PATCH 02/11] block: rename block_bio_merge class to block_bio Chaitanya Kulkarni
2020-06-30 5:10 ` Christoph Hellwig
2020-07-01 4:33 ` Chaitanya Kulkarni
2020-06-29 23:43 ` [PATCH 03/11] block: use block_bio event class for bio_queue Chaitanya Kulkarni
2020-06-29 23:43 ` [PATCH 04/11] block: use block_bio event class for bio_bounce Chaitanya Kulkarni
2020-06-29 23:43 ` [PATCH 05/11] block: get rid of the trace rq insert wrapper Chaitanya Kulkarni
2020-06-30 5:11 ` Christoph Hellwig
2020-07-01 4:34 ` Chaitanya Kulkarni
2020-07-03 23:29 ` Chaitanya Kulkarni
2020-07-07 6:57 ` hch
2020-06-29 23:43 ` [PATCH 06/11] block: remove extra param for trace_block_getrq() Chaitanya Kulkarni
2020-06-29 23:43 ` [PATCH 07/11] block: get rid of blk_trace_request_get_cgid() Chaitanya Kulkarni
2020-06-30 5:12 ` Christoph Hellwig
2020-07-01 4:38 ` Chaitanya Kulkarni
2020-07-01 6:16 ` Christoph Hellwig
2020-07-01 21:06 ` Chaitanya Kulkarni
2020-06-29 23:43 ` [PATCH 08/11] block: fix the comments in the trace event block.h Chaitanya Kulkarni
2020-06-30 5:12 ` Christoph Hellwig
2020-06-29 23:43 ` [PATCH 09/11] block: remove unsed param in blk_fill_rwbs() Chaitanya Kulkarni
2020-06-30 5:12 ` Christoph Hellwig
2020-07-01 4:38 ` Chaitanya Kulkarni
2020-06-29 23:43 ` [PATCH 10/11] block: use block_bio class for getrq and sleeprq Chaitanya Kulkarni
2020-06-30 5:13 ` Christoph Hellwig
2020-07-01 4:45 ` Chaitanya Kulkarni
2020-07-01 6:18 ` Christoph Hellwig
2020-07-01 21:06 ` Chaitanya Kulkarni
2020-06-29 23:43 ` [PATCH 11/11] block: remove block_get_rq event class Chaitanya Kulkarni
2020-06-30 0:58 ` Steven Rostedt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200629205853.38628a63@oasis.local.home \
--to=rostedt@goodmis.org \
--cc=agk@redhat.com \
--cc=axboe@kernel.dk \
--cc=bvanassche@acm.org \
--cc=chaitanya.kulkarni@wdc.com \
--cc=colyli@suse.de \
--cc=dm-devel@redhat.com \
--cc=fangguoju@gmail.com \
--cc=hch@lst.de \
--cc=jack@suse.czi \
--cc=linux-block@vger.kernel.org \
--cc=ming.lei@redhat.com \
--cc=mingo@redhat.com \
--cc=paolo.valente@linaro.org \
--cc=rdunlap@infradead.org \
--cc=sagi@grimberg.me \
--cc=snitzer@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).