From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5E3F4C433E0 for ; Thu, 2 Jul 2020 15:21:46 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3889B208B8 for ; Thu, 2 Jul 2020 15:21:46 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="fz3Jh9Eb" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730048AbgGBPVn (ORCPT ); Thu, 2 Jul 2020 11:21:43 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55734 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729436AbgGBPVm (ORCPT ); Thu, 2 Jul 2020 11:21:42 -0400 Received: from mail-pl1-x644.google.com (mail-pl1-x644.google.com [IPv6:2607:f8b0:4864:20::644]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8EF02C08C5E0 for ; Thu, 2 Jul 2020 08:21:42 -0700 (PDT) Received: by mail-pl1-x644.google.com with SMTP id d10so11439979pls.5 for ; Thu, 02 Jul 2020 08:21:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=85NgcoW6jBNBGz0tQzl+oqewL1I9o/iwYquf90s0iyI=; b=fz3Jh9EbW2QNq/2MyLiNywl+Bw+HpwfpGyCppJTlFpNOcSFS1TexJkrkG1UxqufMgU DTnt8qDgoR6kpc5Uov/N8ZFtF9gBkglTu3rbJlgEgXDnMffWLDd4jgcOStrGlPxU6l/S kAv+vOh2+5LMMHeltnDKRB/tSSiTCWUefTVYo= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=85NgcoW6jBNBGz0tQzl+oqewL1I9o/iwYquf90s0iyI=; b=GfXu8C45U7qWwySWL9LingNU49xUTlt/q5QWxf70Ije9IltrCmo6tLVjqYJ4sj3D1N NiIaPaQ4Z7Huf1bJ9pROieN+kMslfw3E9qcaAIqy3Y/MqgTR1JX1pd5awAbt4TNvVm0X X1eZjY+E7siQ4JsBBr9pdBLPtWeGzSHCu/m3mEBcAsnpmECk1JJZVjeAzCL0H4wekN8d me7a0MkMib2Fzo25D4EN+bu9jvEKqKX3q3mbc1OZSu+t9qmWtMFP+IDdI3ZusehVMK7j K/1Fcc83FM6laJuSScWstVQrZdTBgMLW4vvgii+4TZcC9D807DV7DG6zgvgqPsHy9gjl /XYQ== X-Gm-Message-State: AOAM5325OOIVfaTyhbeNn+/+B2DfcYuzOb9dAYvnsV7M51jGDdL63/Jy qtkKlB9IHNNeB0aGYw9vtdGRaQ== X-Google-Smtp-Source: ABdhPJyPnF33faJF3QEw2ElnpTvwp44zuiTBz6WWqS/hEjfBUUANHOACCnQyGoZR2gBcK7ir4/OsKg== X-Received: by 2002:a17:90a:cb0e:: with SMTP id z14mr31267430pjt.140.1593703302136; Thu, 02 Jul 2020 08:21:42 -0700 (PDT) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id c19sm8151174pjs.11.2020.07.02.08.21.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 02 Jul 2020 08:21:41 -0700 (PDT) Date: Thu, 2 Jul 2020 08:21:40 -0700 From: Kees Cook To: Mark Brown Cc: linux-kernel@vger.kernel.org, Nick Desaulniers , Linus Torvalds , Miguel Ojeda , Alexander Potapenko , Joe Perches , Andy Whitcroft , x86@kernel.org, drbd-dev@lists.linbit.com, linux-block@vger.kernel.org, b43-dev@lists.infradead.org, netdev@vger.kernel.org, linux-doc@vger.kernel.org, linux-wireless@vger.kernel.org, linux-ide@vger.kernel.org, linux-clk@vger.kernel.org, linux-spi@vger.kernel.org, linux-mm@kvack.org, clang-built-linux@googlegroups.com Subject: Re: [PATCH v2 08/16] spi: davinci: Remove uninitialized_var() usage Message-ID: <202007020819.318824DA@keescook> References: <20200620033007.1444705-1-keescook@chromium.org> <20200620033007.1444705-9-keescook@chromium.org> <20200701203920.GC3776@sirena.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200701203920.GC3776@sirena.org.uk> Sender: linux-block-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org On Wed, Jul 01, 2020 at 09:39:20PM +0100, Mark Brown wrote: > On Fri, Jun 19, 2020 at 08:29:59PM -0700, Kees Cook wrote: > > Using uninitialized_var() is dangerous as it papers over real bugs[1] > > (or can in the future), and suppresses unrelated compiler warnings (e.g. > > "unused variable"). If the compiler thinks it is uninitialized, either > > simply initialize the variable or make compiler changes. As a precursor > > to removing[2] this[3] macro[4], just remove this variable since it was > > actually unused: > > Please copy maintainers on patches :( Hi! Sorry about that; the CC list was giant, so I had opted for using subsystem mailing lists where possible. > Acked-by: Mark Brown Thanks! -- Kees Cook