From: "Javier González" <javier@javigon.com>
To: Johannes Thumshirn <Johannes.Thumshirn@wdc.com>
Cc: "linux-nvme@lists.infradead.org" <linux-nvme@lists.infradead.org>,
"linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
"hch@lst.de" <hch@lst.de>,
"kbusch@kernel.org" <kbusch@kernel.org>,
"sagi@grimberg.me" <sagi@grimberg.me>,
"axboe@kernel.dk" <axboe@kernel.dk>,
Damien Le Moal <Damien.LeMoal@wdc.com>,
"mb@lightnvm.io" <mb@lightnvm.io>,
SelvaKumar S <selvakuma.s1@samsung.com>,
Kanchan Joshi <joshi.k@samsung.com>,
Nitesh Shetty <nj.shetty@samsung.com>
Subject: Re: [PATCH 3/4] nvme: Add consistency check for zone count
Date: Thu, 2 Jul 2020 10:27:34 +0200 [thread overview]
Message-ID: <20200702082734.pb775iqyqkm2if6w@mpHalley.local> (raw)
In-Reply-To: <SN4PR0401MB3598D462060502A55417B1399B6D0@SN4PR0401MB3598.namprd04.prod.outlook.com>
On 02.07.2020 08:19, Johannes Thumshirn wrote:
>On 02/07/2020 08:55, Javier González wrote:
>> int nvme_update_zone_info(struct gendisk *disk, struct nvme_ns *ns,
>> - unsigned lbaf)
>> + unsigned int lbaf, sector_t nsze)
>> {
>> // struct nvme_effects_log *log = ns->head->effects;
>> struct request_queue *q = disk->queue;
>
>
>Please no C++ style comments and no commenting out of code in an official submission.
Sorry. I see some debug code leaked here.
Javier
next prev parent reply other threads:[~2020-07-02 8:27 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-02 6:54 [V2 PATCH 0/4] ZNS: Extra features for current patche Javier González
2020-07-02 6:54 ` [PATCH 1/4] block: Add zone flags to queue zone prop Javier González
2020-07-02 7:54 ` Damien Le Moal
2020-07-02 8:34 ` Javier González
2020-07-02 8:49 ` Damien Le Moal
2020-07-02 10:27 ` Javier González
2020-07-03 5:20 ` Damien Le Moal
2020-07-03 6:28 ` Javier González
2020-07-03 8:35 ` Damien Le Moal
2020-07-02 6:54 ` [PATCH 2/4] block: add support for zone offline transition Javier González
2020-07-02 8:10 ` Damien Le Moal
2020-07-02 8:39 ` Javier González
2020-07-02 8:52 ` Damien Le Moal
2020-07-02 6:54 ` [PATCH 3/4] nvme: Add consistency check for zone count Javier González
2020-07-02 8:16 ` Damien Le Moal
2020-07-02 8:19 ` Johannes Thumshirn
2020-07-02 8:27 ` Javier González [this message]
2020-07-02 6:54 ` [PATCH 4/4] block: add attributes to zone report Javier González
2020-07-02 8:27 ` Damien Le Moal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200702082734.pb775iqyqkm2if6w@mpHalley.local \
--to=javier@javigon.com \
--cc=Damien.LeMoal@wdc.com \
--cc=Johannes.Thumshirn@wdc.com \
--cc=axboe@kernel.dk \
--cc=hch@lst.de \
--cc=joshi.k@samsung.com \
--cc=kbusch@kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=mb@lightnvm.io \
--cc=nj.shetty@samsung.com \
--cc=sagi@grimberg.me \
--cc=selvakuma.s1@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).