From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C2730C433E0 for ; Wed, 8 Jul 2020 15:04:25 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 968EC2078D for ; Wed, 8 Jul 2020 15:04:25 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="CG4COg6x" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729206AbgGHPEZ (ORCPT ); Wed, 8 Jul 2020 11:04:25 -0400 Received: from us-smtp-delivery-1.mimecast.com ([207.211.31.120]:40036 "EHLO us-smtp-1.mimecast.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1729022AbgGHPEY (ORCPT ); Wed, 8 Jul 2020 11:04:24 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1594220663; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=cCfFQ9unhV8AALYAbnlDEYp86FEPgYE4PEBMEl3tJ+k=; b=CG4COg6xclwjEypPnhQtXV6DUNMAczbN/JgdbKn8fC7f6HCvgw8b8O0IOIKZV/+RNDcggb sRhQtnvWezBfEZYeZeljLHpPTjVJhcDGhfUNHXWsJWdSCZFdeq7kEUSuEIFf1anZ97CwKR m43qinSj3RxIaW8/PSWCZ50I8nUig0g= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-461-_cOtDcHDMqSgQS042k_P3g-1; Wed, 08 Jul 2020 11:04:20 -0400 X-MC-Unique: _cOtDcHDMqSgQS042k_P3g-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 47FA510506EE; Wed, 8 Jul 2020 15:04:18 +0000 (UTC) Received: from localhost (unknown [10.18.25.174]) by smtp.corp.redhat.com (Postfix) with ESMTPS id DC18910013D7; Wed, 8 Jul 2020 15:04:14 +0000 (UTC) Date: Wed, 8 Jul 2020 10:02:54 -0400 From: Mike Snitzer To: Christoph Hellwig Cc: Jens Axboe , Tejun Heo , cgroups@vger.kernel.org, linux-kernel@vger.kernel.org, linux-block@vger.kernel.org, linux-mm@kvack.org, dm-devel@redhat.com, Li Zefan , Johannes Weiner , Dennis Zhou Subject: Re: [PATCH 01/14] dm: use bio_uninit instead of bio_disassociate_blkg Message-ID: <20200708140254.GA7539@redhat.com> References: <20200627073159.2447325-1-hch@lst.de> <20200627073159.2447325-2-hch@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200627073159.2447325-2-hch@lst.de> User-Agent: Mutt/1.5.21 (2010-09-15) X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 Sender: linux-block-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org On Sat, Jun 27 2020 at 3:31am -0400, Christoph Hellwig wrote: > bio_uninit is the proper API to clean up a BIO that has been allocated > on stack or inside a structure that doesn't come from the BIO allocator. > Switch dm to use that instead of bio_disassociate_blkg, which really is > an implementation detail. Note that the bio_uninit calls are also moved > to the two callers of __send_empty_flush, so that they better pair with > the bio_init calls used to initialize them. > > Signed-off-by: Christoph Hellwig I've picked this up as a fix for 5.8 Thanks, Mike