From: Christoph Hellwig <hch@lst.de>
To: Jens Axboe <axboe@kernel.dk>
Cc: Christoph Hellwig <hch@lst.de>, Tejun Heo <tj@kernel.org>,
dm-devel@redhat.com, cgroups@vger.kernel.org,
linux-block@vger.kernel.org, drbd-dev@lists.linbit.com,
linux-bcache@vger.kernel.org, linux-raid@vger.kernel.org,
linux-btrfs@vger.kernel.org, linux-mm@kvack.org,
linux-kernel@vger.kernel.org
Subject: Re: remove dead bdi congestion leftovers
Date: Thu, 9 Jul 2020 16:01:45 +0200 [thread overview]
Message-ID: <20200709140145.GA3068@lst.de> (raw)
In-Reply-To: <82e2785d-2091-1986-0014-3b7cea7cd0d8@kernel.dk>
On Thu, Jul 09, 2020 at 07:58:58AM -0600, Jens Axboe wrote:
> On 7/8/20 11:32 PM, Christoph Hellwig wrote:
> > On Wed, Jul 08, 2020 at 05:14:29PM -0600, Jens Axboe wrote:
> >> On 7/1/20 3:06 AM, Christoph Hellwig wrote:
> >>> Hi Jens,
> >>>
> >>> we have a lot of bdi congestion related code that is left around without
> >>> any use. This series removes it in preparation of sorting out the bdi
> >>> lifetime rules properly.
> >>
> >> Please run series like this through a full compilation, for both this one
> >> and the previous series I had to fix up issues like this:
> >>
> >> drivers/md/bcache/request.c: In function ‘bch_cached_dev_request_init’:
> >> drivers/md/bcache/request.c:1233:18: warning: unused variable ‘g’ [-Wunused-variable]
> >> 1233 | struct gendisk *g = dc->disk.disk;
> >> | ^
> >> drivers/md/bcache/request.c: In function ‘bch_flash_dev_request_init’:
> >> drivers/md/bcache/request.c:1320:18: warning: unused variable ‘g’ [-Wunused-variable]
> >> 1320 | struct gendisk *g = d->disk;
> >> | ^
> >>
> >> Did the same here, applied it.
> >
> > And just like the previous one I did, and the compiler did not complain.
> > There must be something about certain gcc versions not warning about
> > variables that are initialized but not otherwise used.
>
> Are you using gcc-10? It sucks for that. gcc-9 seems to reliably hit
> these cases for me, not sure why gcc-10 doesn't. And the ones quoted
> above are about as trivial as they can get.
gcc-9.3 from Debian -testing. And yes, I'm really surprised it didn't
find those.
prev parent reply other threads:[~2020-07-09 14:01 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-01 9:06 remove dead bdi congestion leftovers Christoph Hellwig
2020-07-01 9:06 ` [PATCH 1/4] drbd: remove a bogus bdi_rw_congested call Christoph Hellwig
2020-07-01 9:06 ` [PATCH 2/4] writeback: remove {set,clear}_wb_congested Christoph Hellwig
2020-07-01 9:06 ` [PATCH 3/4] writeback: remove struct bdi_writeback_congested Christoph Hellwig
2020-07-01 9:06 ` [PATCH 4/4] writeback: remove bdi->congested_fn Christoph Hellwig
2020-07-01 14:48 ` David Sterba
2020-07-02 0:38 ` Coly Li
2020-07-02 5:36 ` Song Liu
2020-07-01 16:38 ` remove dead bdi congestion leftovers Tejun Heo
2020-07-01 16:41 ` Mike Snitzer
2020-07-01 17:57 ` Matthew Wilcox
2020-07-01 18:25 ` Matthew Wilcox
2020-07-08 23:14 ` Jens Axboe
2020-07-09 5:32 ` Christoph Hellwig
2020-07-09 13:58 ` Jens Axboe
2020-07-09 14:01 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200709140145.GA3068@lst.de \
--to=hch@lst.de \
--cc=axboe@kernel.dk \
--cc=cgroups@vger.kernel.org \
--cc=dm-devel@redhat.com \
--cc=drbd-dev@lists.linbit.com \
--cc=linux-bcache@vger.kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-raid@vger.kernel.org \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).