From: Gabriel Krisman Bertazi <krisman@collabora.com>
To: axboe@kernel.dk
Cc: linux-block@vger.kernel.org,
Gabriel Krisman Bertazi <krisman@collabora.com>,
kernel@collabora.com
Subject: [PATCH] block: Fix inflight statistic for MQ submission with !elevator
Date: Mon, 31 Aug 2020 11:31:27 -0400 [thread overview]
Message-ID: <20200831153127.3561733-1-krisman@collabora.com> (raw)
According to Documentation/block/stat.rst, inflight should not include
I/O requests that are in the queue but not yet dispatched to the device,
but blk-mq identifies as inflight any request that has a tag allocated,
which, for queues without elevator, happens at request allocation time
and before it is queued in the ctx (default case in blk_mq_submit_bio).
A more precise approach would be to only consider requests with state
MQ_RQ_IN_FLIGHT.
Signed-off-by: Gabriel Krisman Bertazi <krisman@collabora.com>
---
block/blk-mq.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/block/blk-mq.c b/block/blk-mq.c
index 0015a1892153..997b3327eaa8 100644
--- a/block/blk-mq.c
+++ b/block/blk-mq.c
@@ -105,7 +105,7 @@ static bool blk_mq_check_inflight(struct blk_mq_hw_ctx *hctx,
{
struct mq_inflight *mi = priv;
- if (rq->part == mi->part)
+ if (rq->part == mi->part && rq->state == MQ_RQ_IN_FLIGHT)
mi->inflight[rq_data_dir(rq)]++;
return true;
--
2.28.0
next reply other threads:[~2020-08-31 15:33 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-31 15:31 Gabriel Krisman Bertazi [this message]
2020-08-31 15:33 ` [PATCH] block: Fix inflight statistic for MQ submission with !elevator Jens Axboe
2020-08-31 15:50 ` Gabriel Krisman Bertazi
2020-09-01 1:18 ` Ming Lei
2020-09-01 3:42 ` Jens Axboe
2020-09-01 6:36 ` Ming Lei
2020-09-01 22:37 ` Jens Axboe
2020-09-01 18:37 ` Gabriel Krisman Bertazi
2020-09-01 22:39 ` Jens Axboe
2020-09-02 20:19 ` [PATCH v2] block: Consider only dispatched requests for inflight statistic Gabriel Krisman Bertazi
2020-09-15 16:11 ` Gabriel Krisman Bertazi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200831153127.3561733-1-krisman@collabora.com \
--to=krisman@collabora.com \
--cc=axboe@kernel.dk \
--cc=kernel@collabora.com \
--cc=linux-block@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).