From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E2585C2BBDB for ; Wed, 2 Sep 2020 15:31:57 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id CA1B9207EA for ; Wed, 2 Sep 2020 15:31:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728161AbgIBPbh (ORCPT ); Wed, 2 Sep 2020 11:31:37 -0400 Received: from verein.lst.de ([213.95.11.211]:32841 "EHLO verein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728329AbgIBPbf (ORCPT ); Wed, 2 Sep 2020 11:31:35 -0400 Received: by verein.lst.de (Postfix, from userid 2407) id 4B24C68B05; Wed, 2 Sep 2020 17:31:30 +0200 (CEST) Date: Wed, 2 Sep 2020 17:31:29 +0200 From: Christoph Hellwig To: Johannes Thumshirn Cc: Christoph Hellwig , Jens Axboe , Denis Efremov , Tim Waugh , Michal Simek , Borislav Petkov , "David S. Miller" , Song Liu , "Martin K. Petersen" , Finn Thain , Michael Schmitz , "linux-m68k@lists.linux-m68k.org" , "linux-block@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-ide@vger.kernel.org" , "linux-raid@vger.kernel.org" , "linux-scsi@vger.kernel.org" , "linux-fsdevel@vger.kernel.org" Subject: Re: [PATCH 05/19] swim: use bdev_check_media_change Message-ID: <20200902153129.GA2304@lst.de> References: <20200902141218.212614-1-hch@lst.de> <20200902141218.212614-6-hch@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.17 (2007-11-01) Sender: linux-block-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org On Wed, Sep 02, 2020 at 03:30:14PM +0000, Johannes Thumshirn wrote: > Looks good, > Reviewed-by: Johannes Thumshirn > > > +static int floppy_revalidate(struct gendisk *disk); > > Completely unrelated to this series but, this is the 3rd floppy > driver in the series defining it's own floppy_revalidate() and > naming it floppy_revalidate(). > > This makes grepping and reviewing a pain. Yes, I noticed it as well. They also use the floppy_ prefix for various other methods. > ---end quoted text---