linux-block.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Logan Gunthorpe <logang@deltatee.com>
To: linux-kernel@vger.kernel.org, linux-nvme@lists.infradead.org,
	linux-block@vger.kernel.org, Omar Sandoval <osandov@osandov.com>
Cc: Sagi Grimberg <sagi@grimberg.me>,
	Chaitanya Kulkarni <Chaitanya.Kulkarni@wdc.com>,
	Stephen Bates <sbates@raithlin.com>,
	Logan Gunthorpe <logang@deltatee.com>
Subject: [PATCH blktests v3 11/11] nvme/038: Test removal of un-enabled subsystem and ports
Date: Thu,  8 Oct 2020 10:40:24 -0600	[thread overview]
Message-ID: <20201008164024.12546-12-logang@deltatee.com> (raw)
In-Reply-To: <20201008164024.12546-1-logang@deltatee.com>

Test that we can remove a subsystem that has not been enabled by
passthru or any ns. Do the same for ports while we are at it.

This was an issue in the original passthru patches and is
not commonly tested. So this test will ensure we don't regress this.

Signed-off-by: Logan Gunthorpe <logang@deltatee.com>
---
 tests/nvme/038     | 36 ++++++++++++++++++++++++++++++++++++
 tests/nvme/038.out |  2 ++
 2 files changed, 38 insertions(+)
 create mode 100755 tests/nvme/038
 create mode 100644 tests/nvme/038.out

diff --git a/tests/nvme/038 b/tests/nvme/038
new file mode 100755
index 000000000000..24f02d4ad4d1
--- /dev/null
+++ b/tests/nvme/038
@@ -0,0 +1,36 @@
+#!/bin/bash
+# SPDX-License-Identifier: GPL-3.0+
+# Copyright (C) 2019 Logan Gunthorpe
+# Copyright (C) 2019 Eideticom Communications Inc.
+#
+# Test that we can remove a subsystem that has not been enabled by
+# passthru or any ns. Do the same for ports while we are at it.
+#
+# This was an issue in the original passthru patches and is
+# not commonly tested. So this test will ensure we don't regress this.
+#
+. tests/nvme/rc
+
+DESCRIPTION="test deletion of NVMeOF subsystem without enabling"
+QUICK=1
+
+requires() {
+	_nvme_requires
+}
+
+test() {
+	local subsys_path="${NVMET_CFS}/subsystems/blktests-subsystem-1"
+	local port
+
+	echo "Running ${TEST_NAME}"
+
+	_setup_nvmet
+
+	mkdir -p "${subsys_path}"
+	rmdir "${subsys_path}"
+
+	port=$(_create_nvmet_port loop)
+	_remove_nvmet_port "${port}"
+
+	echo "Test complete"
+}
diff --git a/tests/nvme/038.out b/tests/nvme/038.out
new file mode 100644
index 000000000000..06bc98022c33
--- /dev/null
+++ b/tests/nvme/038.out
@@ -0,0 +1,2 @@
+Running nvme/038
+Test complete
-- 
2.20.1


  parent reply	other threads:[~2020-10-08 16:41 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-08 16:40 [PATCH blktests v3 00/11] NVMe Target Passthru Block Tests Logan Gunthorpe
2020-10-08 16:40 ` [PATCH blktests v3 01/11] common/fio: Remove state file in common helper Logan Gunthorpe
2020-10-08 16:40 ` [PATCH blktests v3 02/11] common/xfs: Create common helper to check for XFS support Logan Gunthorpe
2020-10-08 16:40 ` [PATCH blktests v3 03/11] common/xfs: Create common helper to verify block device with xfs Logan Gunthorpe
2020-10-08 16:40 ` [PATCH blktests v3 04/11] nvme: Search for specific subsysnqn in _find_nvme_loop_dev Logan Gunthorpe
2020-10-08 16:40 ` [PATCH blktests v3 05/11] nvme: Add common helpers for passthru tests Logan Gunthorpe
2020-10-08 16:40 ` [PATCH blktests v3 06/11] nvme/033: Simple test to create and connect to a passthru target Logan Gunthorpe
2020-10-08 16:40 ` [PATCH blktests v3 07/11] nvme/034: Add test for passthru data verification Logan Gunthorpe
2020-10-08 16:40 ` [PATCH blktests v3 08/11] nvme/035: Add test to verify passthru controller with a filesystem Logan Gunthorpe
2020-10-08 16:40 ` [PATCH blktests v3 09/11] nvme/036: Add test for testing reset command on nvme-passthru Logan Gunthorpe
2020-10-08 16:40 ` [PATCH blktests v3 10/11] nvme/037: Add test which loops passthru connect and disconnect Logan Gunthorpe
2020-10-08 16:40 ` Logan Gunthorpe [this message]
2020-10-22 18:45 ` [PATCH blktests v3 00/11] NVMe Target Passthru Block Tests Logan Gunthorpe
2020-10-22 22:04   ` Omar Sandoval
2020-10-22 22:25     ` Logan Gunthorpe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201008164024.12546-12-logang@deltatee.com \
    --to=logang@deltatee.com \
    --cc=Chaitanya.Kulkarni@wdc.com \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-nvme@lists.infradead.org \
    --cc=osandov@osandov.com \
    --cc=sagi@grimberg.me \
    --cc=sbates@raithlin.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).