linux-block.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@infradead.org>
To: Jeffle Xu <jefflexu@linux.alibaba.com>
Cc: axboe@kernel.dk, hch@infradead.org, viro@zeniv.linux.org.uk,
	linux-fsdevel@vger.kernel.org, linux-block@vger.kernel.org,
	ming.lei@redhat.com, joseph.qi@linux.alibaba.com,
	xiaoguang.wang@linux.alibaba.com
Subject: Re: [v2 1/2] block: disable iopoll for split bio
Date: Thu, 15 Oct 2020 08:58:18 +0100	[thread overview]
Message-ID: <20201015075818.GA30117@infradead.org> (raw)
In-Reply-To: <20201015074031.91380-2-jefflexu@linux.alibaba.com>

> +
> +	/*
> +	 * IOpoll is initially for small size, latency sensitive IO.
> +	 *
> +	 * It doesn't work well for big IO, especially when it needs to be split to
> +	 * multiple bios. When it comes to bio split, the returned cookie of
> +	 * __submit_bio_noacct_mq() is indeed the cookie of the last split bio. The
> +	 * completion of *this* last split bio done by polling doesn't mean the whole

Please fix the various overly long lines.

  reply	other threads:[~2020-10-15  7:58 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-15  7:40 [v2 0/2] block, iomap: disable iopoll for split bio Jeffle Xu
2020-10-15  7:40 ` [v2 1/2] block: " Jeffle Xu
2020-10-15  7:58   ` Christoph Hellwig [this message]
2020-10-15  7:40 ` [v2 2/2] block,iomap: disable iopoll when split needed Jeffle Xu
2020-10-15  7:59   ` Christoph Hellwig
2020-10-15  8:47     ` JeffleXu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201015075818.GA30117@infradead.org \
    --to=hch@infradead.org \
    --cc=axboe@kernel.dk \
    --cc=jefflexu@linux.alibaba.com \
    --cc=joseph.qi@linux.alibaba.com \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=ming.lei@redhat.com \
    --cc=viro@zeniv.linux.org.uk \
    --cc=xiaoguang.wang@linux.alibaba.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).