linux-block.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: kernel test robot <lkp@intel.com>
To: Kashyap Desai <kashyap.desai@broadcom.com>, linux-scsi@vger.kernel.org
Cc: kbuild-all@lists.01.org, clang-built-linux@googlegroups.com,
	Kashyap Desai <kashyap.desai@broadcom.com>,
	sumit.saxena@broadcom.com, chandrakanth.patil@broadcom.com,
	linux-block@vger.kernel.org
Subject: Re: [PATCH v1 2/3] megaraid_sas: iouring iopoll support
Date: Fri, 16 Oct 2020 04:44:01 +0800	[thread overview]
Message-ID: <202010160414.1xDVx7Gh-lkp@intel.com> (raw)
In-Reply-To: <20201015133702.62879-1-kashyap.desai@broadcom.com>

[-- Attachment #1: Type: text/plain, Size: 2985 bytes --]

Hi Kashyap,

I love your patch! Perhaps something to improve:

[auto build test WARNING on next-20201015]
[cannot apply to scsi/for-next mkp-scsi/for-next v5.9 v5.9-rc8 v5.9-rc7 v5.9]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Kashyap-Desai/io_uring-iopoll-in-scsi-layer/20201015-213946
base:    03d992bd2de6c7f2c9bbd4260ff104c0926ce3ff
config: riscv-randconfig-r026-20201015 (attached as .config)
compiler: clang version 12.0.0 (https://github.com/llvm/llvm-project e7b4feea8e1bf520b34ad8c116abab6677344b74)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # install riscv cross compiling tool for clang build
        # apt-get install binutils-riscv64-linux-gnu
        # https://github.com/0day-ci/linux/commit/011c9682f4ab6651d3b56e7bb819b6605e1f8d32
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Kashyap-Desai/io_uring-iopoll-in-scsi-layer/20201015-213946
        git checkout 011c9682f4ab6651d3b56e7bb819b6605e1f8d32
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=riscv 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

>> drivers/scsi/megaraid/megaraid_sas_fusion.c:3652:5: warning: no previous prototype for function 'megasas_blk_mq_poll' [-Wmissing-prototypes]
   int megasas_blk_mq_poll(struct Scsi_Host *shost, unsigned int queue_num)
       ^
   drivers/scsi/megaraid/megaraid_sas_fusion.c:3652:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
   int megasas_blk_mq_poll(struct Scsi_Host *shost, unsigned int queue_num)
   ^
   static 
   1 warning generated.

vim +/megasas_blk_mq_poll +3652 drivers/scsi/megaraid/megaraid_sas_fusion.c

  3651	
> 3652	int megasas_blk_mq_poll(struct Scsi_Host *shost, unsigned int queue_num)
  3653	{
  3654	
  3655		struct megasas_instance *instance;
  3656		int num_entries = 0;
  3657		struct fusion_context *fusion;
  3658	
  3659		instance = (struct megasas_instance *)shost->hostdata;
  3660	
  3661		fusion = instance->ctrl_context;
  3662	
  3663		queue_num = queue_num + instance->low_latency_index_start;
  3664	
  3665		if (!atomic_add_unless(&fusion->busy_mq_poll[queue_num], 1, 1))
  3666			return 0;
  3667	
  3668		num_entries = complete_cmd_fusion(instance, queue_num, NULL);
  3669		atomic_dec(&fusion->busy_mq_poll[queue_num]);
  3670	
  3671		return num_entries;
  3672	}
  3673	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 28577 bytes --]

  reply	other threads:[~2020-10-15 20:44 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-15 13:37 [PATCH v1 2/3] megaraid_sas: iouring iopoll support Kashyap Desai
2020-10-15 20:44 ` kernel test robot [this message]
2020-11-13 10:48 ` Kashyap Desai
2020-11-13 11:56 ` chenxiang (M)
2020-11-20  7:14 ` Hannes Reinecke
2020-11-20  8:32   ` John Garry
2020-11-30  9:17     ` Kashyap Desai
2020-11-30  9:40       ` John Garry

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=202010160414.1xDVx7Gh-lkp@intel.com \
    --to=lkp@intel.com \
    --cc=chandrakanth.patil@broadcom.com \
    --cc=clang-built-linux@googlegroups.com \
    --cc=kashyap.desai@broadcom.com \
    --cc=kbuild-all@lists.01.org \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=sumit.saxena@broadcom.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).