From: Tejun Heo <tj@kernel.org>
To: Muneendra Kumar M <muneendra.kumar@broadcom.com>
Cc: linux-block@vger.kernel.org, linux-scsi@vger.kernel.org,
linux-nvme@lists.infradead.org, jsmart2021@gmail.com,
emilne@redhat.com, mkumar@redhat.com, pbonzini@redhat.com
Subject: Re: [RFC v2 02/18] blkcg: Added a app identifier support for blkcg
Date: Mon, 19 Oct 2020 11:19:35 -0400 [thread overview]
Message-ID: <20201019151935.GD4418@mtj.thefacebook.com> (raw)
In-Reply-To: <ab237522d9110888aaaa538519f3af7d@mail.gmail.com>
On Mon, Oct 19, 2020 at 08:43:05PM +0530, Muneendra Kumar M wrote:
> Hi Tejun,
> Thanks for the input.
> >> + cgrp = cgroup_get_from_kernfs_id(id);
> >> + if (!cgrp)
> >> + return -ENOENT;
> >> +
> > >+ css = cgroup_get_e_css(cgrp, &io_cgrp_subsys);
> >> + if (!css)
> >> + return -ENOENT;
> >> +
> >> + blkcg = css_to_blkcg(css);
> >> + if (!blkcg)
> >> + return -ENOENT;
> > >+ return -EINVAL;
> > >+ strlcpy(blkcg->app_id, buf, len);
>
> >Shouldn't the cgrp and css be put before exit?
> [Muneendra]Correct me if iam wrong.
> You mean to add cgroup_put(cgrp) and css_put(css) before exit ?
Yeah, as-is it'd leak references each time the function is called.
Thanks.
--
tejun
next prev parent reply other threads:[~2020-10-19 15:19 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-19 7:42 [RFC v2 00/18] blkcg:Support to track FC storage blk io traffic Muneendra
2020-10-19 7:42 ` [RFC v2 01/18] cgroup: Added cgroup_get_from_kernfs_id Muneendra
2020-10-19 14:43 ` Tejun Heo
2020-10-19 7:42 ` [RFC v2 02/18] blkcg: Added a app identifier support for blkcg Muneendra
2020-10-19 14:46 ` Tejun Heo
2020-10-19 15:13 ` Muneendra Kumar M
2020-10-19 15:19 ` Tejun Heo [this message]
2020-10-19 15:20 ` Muneendra Kumar M
2020-10-19 7:42 ` [RFC v2 03/18] nvme: Added a newsysfs attribute appid_store Muneendra
2020-10-19 7:42 ` [RFC v2 04/18] lpfc: vmid: Add the datastructure for supporting VMID in lpfc Muneendra
2020-10-19 7:43 ` [RFC v2 05/18] lpfc: vmid: API to check if VMID is enabled Muneendra
2020-10-19 7:43 ` [RFC v2 06/18] lpfc: vmid: Supplementary data structures for vmid Muneendra
2020-10-19 7:43 ` [RFC v2 07/18] lpfc: vmid: Forward declarations for APIs Muneendra
2020-10-19 7:43 ` [RFC v2 08/18] lpfc: vmid: Add support for vmid in mailbox command Muneendra
2020-10-19 7:43 ` [RFC v2 09/18] lpfc: vmid: VMID params initialization Muneendra
2020-10-19 7:43 ` [RFC v2 10/18] lpfc: vmid: vmid resource allocation Muneendra
2020-10-19 7:43 ` [RFC v2 11/18] lpfc: vmid: cleanup vmid resources Muneendra
2020-10-19 7:43 ` [RFC v2 12/18] lpfc: vmid: Implements ELS commands for appid patch Muneendra
2020-10-19 7:43 ` [RFC v2 13/18] lpfc: vmid: Functions to manage vmids Muneendra
2020-10-19 7:43 ` [RFC v2 14/18] lpfc: vmid: Implements CT commands for appid Muneendra
2020-10-19 7:43 ` [RFC v2 15/18] lpfc: vmid: Appends the vmid in the wqe before sending request Muneendra
2020-10-19 7:43 ` [RFC v2 16/18] lpfc: vmid: Timeout implementation for vmid Muneendra
2020-10-19 7:43 ` [RFC v2 17/18] lpfc: vmid: Adding qfpa and vmid timeout check in worker thread Muneendra
2020-10-19 7:43 ` [RFC v2 18/18] lpfc: vmid: Introducing vmid in io path Muneendra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201019151935.GD4418@mtj.thefacebook.com \
--to=tj@kernel.org \
--cc=emilne@redhat.com \
--cc=jsmart2021@gmail.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=linux-scsi@vger.kernel.org \
--cc=mkumar@redhat.com \
--cc=muneendra.kumar@broadcom.com \
--cc=pbonzini@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).