From: Christoph Hellwig <hch@lst.de>
To: Jens Axboe <axboe@kernel.dk>
Cc: Ilya Dryomov <idryomov@gmail.com>, Song Liu <song@kernel.org>,
Miquel Raynal <miquel.raynal@bootlin.com>,
Richard Weinberger <richard@nod.at>,
Vignesh Raghavendra <vigneshr@ti.com>,
Stefan Haberland <sth@linux.ibm.com>,
Jan Hoeppner <hoeppner@linux.ibm.com>,
linux-block@vger.kernel.org, ceph-devel@vger.kernel.org,
linux-bcache@vger.kernel.org, linux-raid@vger.kernel.org,
linux-mtd@lists.infradead.org, linux-s390@vger.kernel.org
Subject: [PATCH 02/11] mtip32xx: return -ENOTTY for all unhanled ioctls
Date: Sat, 31 Oct 2020 09:58:01 +0100 [thread overview]
Message-ID: <20201031085810.450489-3-hch@lst.de> (raw)
In-Reply-To: <20201031085810.450489-1-hch@lst.de>
-ENOTTY is the convention for "driver does not support this ioctl".
Use it properly in mtip32xx instead of the bogys -EINVAL.
Signed-off-by: Christoph Hellwig <hch@lst.de>
---
drivers/block/mtip32xx/mtip32xx.c | 11 ++---------
1 file changed, 2 insertions(+), 9 deletions(-)
diff --git a/drivers/block/mtip32xx/mtip32xx.c b/drivers/block/mtip32xx/mtip32xx.c
index 153e2cdecb4d40..893be95eceb34e 100644
--- a/drivers/block/mtip32xx/mtip32xx.c
+++ b/drivers/block/mtip32xx/mtip32xx.c
@@ -2029,7 +2029,7 @@ static int mtip_hw_ioctl(struct driver_data *dd, unsigned int cmd,
}
default:
- return -EINVAL;
+ return -ENOTTY;
}
return 0;
}
@@ -3215,12 +3215,7 @@ static int mtip_block_ioctl(struct block_device *dev,
if (unlikely(test_bit(MTIP_DDF_REMOVE_PENDING_BIT, &dd->dd_flag)))
return -ENOTTY;
- switch (cmd) {
- case BLKFLSBUF:
- return -ENOTTY;
- default:
- return mtip_hw_ioctl(dd, cmd, arg);
- }
+ return mtip_hw_ioctl(dd, cmd, arg);
}
#ifdef CONFIG_COMPAT
@@ -3254,8 +3249,6 @@ static int mtip_block_compat_ioctl(struct block_device *dev,
return -ENOTTY;
switch (cmd) {
- case BLKFLSBUF:
- return -ENOTTY;
case HDIO_DRIVE_TASKFILE: {
struct mtip_compat_ide_task_request_s __user *compat_req_task;
ide_task_request_t req_task;
--
2.28.0
next prev parent reply other threads:[~2020-10-31 9:04 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-31 8:57 block ioctl cleanups Christoph Hellwig
2020-10-31 8:58 ` [PATCH 01/11] mtd_blkdevs: don't override BLKFLSBUF Christoph Hellwig
2020-10-31 21:32 ` Richard Weinberger
2020-10-31 23:11 ` antlists
2020-10-31 8:58 ` Christoph Hellwig [this message]
2020-10-31 14:58 ` [PATCH 02/11] mtip32xx: return -ENOTTY for all unhanled ioctls Jens Axboe
2020-11-01 10:27 ` Christoph Hellwig
2020-11-01 16:45 ` Jens Axboe
2020-10-31 8:58 ` [PATCH 03/11] block: don't call into the driver for BLKFLSBUF Christoph Hellwig
2020-10-31 8:58 ` [PATCH 04/11] block: add a new set_read_only method Christoph Hellwig
2020-10-31 8:58 ` [PATCH 05/11] rbd: implement ->set_read_only to hook into BLKROSET processing Christoph Hellwig
2020-11-02 11:30 ` Ilya Dryomov
2020-10-31 8:58 ` [PATCH 06/11] md: " Christoph Hellwig
2020-11-03 0:19 ` James Troup
2020-11-03 9:32 ` Christoph Hellwig
2020-10-31 8:58 ` [PATCH 07/11] dasd: " Christoph Hellwig
2020-10-31 8:58 ` [PATCH 08/11] block: don't call into the driver for BLKROSET Christoph Hellwig
2020-10-31 8:58 ` [PATCH 09/11] loop: use set_disk_ro Christoph Hellwig
2020-10-31 8:58 ` [PATCH 10/11] block: remove set_device_ro Christoph Hellwig
2020-10-31 8:58 ` [PATCH 11/11] block: remove __blkdev_driver_ioctl Christoph Hellwig
2020-11-01 16:46 ` block ioctl cleanups Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201031085810.450489-3-hch@lst.de \
--to=hch@lst.de \
--cc=axboe@kernel.dk \
--cc=ceph-devel@vger.kernel.org \
--cc=hoeppner@linux.ibm.com \
--cc=idryomov@gmail.com \
--cc=linux-bcache@vger.kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=linux-raid@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=miquel.raynal@bootlin.com \
--cc=richard@nod.at \
--cc=song@kernel.org \
--cc=sth@linux.ibm.com \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).