From: Niklas Cassel <Niklas.Cassel@wdc.com>
To: Javier Gonzalez <javier.gonz@samsung.com>
Cc: "kbusch@kernel.org" <kbusch@kernel.org>,
"javier@javigon.com" <javier@javigon.com>,
"linux-nvme@lists.infradead.org" <linux-nvme@lists.infradead.org>,
"linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
"hch@lst.de" <hch@lst.de>, "sagi@grimberg.me" <sagi@grimberg.me>,
"axboe@kernel.dk" <axboe@kernel.dk>,
"joshi.k@samsung.com" <joshi.k@samsung.com>,
"Klaus B. Jensen" <k.jensen@samsung.com>
Subject: Re: [PATCH V2] nvme: report capacity 0 for non supported ZNS SSDs
Date: Mon, 2 Nov 2020 16:30:01 +0000 [thread overview]
Message-ID: <20201102163000.GA203505@localhost.localdomain> (raw)
In-Reply-To: <0916865d50c640e3aa95dc542f3986b9@CAMSVWEXC01.scsc.local>
On Mon, Nov 02, 2020 at 04:15:01PM +0000, Javier Gonzalez wrote:
>
> From: Keith Busch <kbusch@kernel.org>
> Sent: Nov 2, 2020 16:45
> To: Javier González <javier@javigon.com>
> Cc: linux-nvme@lists.infradead.org; linux-block@vger.kernel.org; hch@lst.de; sagi@grimberg.me; axboe@kernel.dk; joshi.k@samsung.com; "Klaus B. Jensen" <k.jensen@samsung.com>; Niklas.Cassel@wdc.com; Javier Gonzalez <javier.gonz@samsung.com>
> Subject: Re: [PATCH V2] nvme: report capacity 0 for non supported ZNS SSDs
>
> On Mon, Nov 02, 2020 at 02:22:14PM +0100, Javier González wrote:
> > Changes since V1:
> > - Apply feedback from Niklas:
> > - Use IS_ENABLED() for checking config option
>
> Your v1 was correct. Using IS_ENBALED() attempts to use an undefined
> symbol when the CONFIG is not enabled:
>
> Oh. Ok. Will return to that.
Keith is correct, sorry for that.
https://www.kernel.org/doc/html/latest/process/coding-style.html#conditional-compilation
"Thus, you still have to use an #ifdef if the code inside the block
references symbols that will not exist if the condition is not met."
Kind regards,
Niklas
>
> drivers/nvme/host/core.c: In function ‘nvme_update_disk_info’:
> drivers/nvme/host/core.c:2056:45: error: ‘struct nvme_ns’ has no member named ‘zoned_ns_supp’
> 2056 | if (IS_ENABLED(CONFIG_BLK_DEV_ZONED) && !ns->zoned_ns_supp)
> | ^~
>
> That said, I don't mind the concept, though I recall Christoph had
> concerns about the existing 0-capacity namespace used for invalid
> formats, so I'd like to hear more on that if he has some spare time to
> comment.
>
> Sounds good. I'll respin a V3 in the meantime. Assuming not supported in the beginning gives problems with non zone namespaces either way. So I'll fix that too.
>
next parent reply other threads:[~2020-11-02 16:30 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20201102161505eucas1p19415e34eb0b14c7eca5a2c648569cf1e@eucas1p1.samsung.com>
[not found] ` <0916865d50c640e3aa95dc542f3986b9@CAMSVWEXC01.scsc.local>
2020-11-02 16:30 ` Niklas Cassel [this message]
2020-11-02 21:25 ` nvme: report capacity 0 for non supported ZNS SSDs Javier Gonzalez
2020-11-02 18:08 ` [PATCH V2] " hch
2020-11-02 18:33 ` Keith Busch
2020-11-02 18:58 ` hch
2020-11-02 21:24 ` Javier Gonzalez
2020-11-03 9:06 ` hch
2020-11-03 14:10 ` Javier Gonzalez
2020-11-03 15:26 ` hch
2020-11-03 15:54 ` Javier Gonzalez
2020-11-04 14:26 ` [PATCH V2] " Hannes Reinecke
2020-11-04 14:29 ` hch
2020-11-04 14:46 ` Hannes Reinecke
2020-11-05 7:37 ` hch
2020-11-05 7:42 ` Hannes Reinecke
2020-11-02 13:22 Javier González
2020-11-02 15:44 ` Keith Busch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201102163000.GA203505@localhost.localdomain \
--to=niklas.cassel@wdc.com \
--cc=axboe@kernel.dk \
--cc=hch@lst.de \
--cc=javier.gonz@samsung.com \
--cc=javier@javigon.com \
--cc=joshi.k@samsung.com \
--cc=k.jensen@samsung.com \
--cc=kbusch@kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).