From: Christoph Hellwig <hch@lst.de>
To: Chaitanya Kulkarni <chaitanya.kulkarni@wdc.com>
Cc: linux-block@vger.kernel.org, linux-nvme@lists.infradead.org,
hch@lst.de, sagi@grimberg.me, kbusch@kernel.org,
logang@deltatee.com
Subject: Re: [PATCH V3 2/6] nvme-core: split nvme_alloc_request()
Date: Tue, 3 Nov 2020 19:24:44 +0100 [thread overview]
Message-ID: <20201103182444.GA23300@lst.de> (raw)
In-Reply-To: <20201022010234.8304-3-chaitanya.kulkarni@wdc.com>
On Wed, Oct 21, 2020 at 06:02:30PM -0700, Chaitanya Kulkarni wrote:
> +static inline unsigned int nvme_req_op(struct nvme_command *cmd)
> +{
> + return nvme_is_write(cmd) ? REQ_OP_DRV_OUT : REQ_OP_DRV_IN;
> +}
Why is this added here while nvme_init_req_from_cmd is added in a prep
patch? I'm actually fine either way, but doing it differnetly for the
different helpers is a little inconsistent.
> +
> +struct request *nvme_alloc_request_qid_any(struct request_queue *q,
> + struct nvme_command *cmd, blk_mq_req_flags_t flags)
I'd call this just nvme_alloc_request to keep the short name for the
normal use case.
> + struct request *req;
> +
> + req = blk_mq_alloc_request(q, nvme_req_op(cmd), flags);
> + if (unlikely(IS_ERR(req)))
> + return req;
> +
> + nvme_init_req_from_cmd(req, cmd);
> + return req;
Could be simplified to:
req = blk_mq_alloc_request(q, nvme_req_op(cmd), flags);
if (!IS_ERR(req))
nvme_init_req_from_cmd(req, cmd);
return req;
Note that IS_ERR already contains an embedded unlikely().
> +static struct request *nvme_alloc_request_qid(struct request_queue *q,
> struct nvme_command *cmd, blk_mq_req_flags_t flags, int qid)
> {
> struct request *req;
>
> + req = blk_mq_alloc_request_hctx(q, nvme_req_op(cmd), flags,
> + qid ? qid - 1 : 0);
> if (IS_ERR(req))
> return req;
>
> nvme_init_req_from_cmd(req, cmd);
> return req;
Same here.
> }
> -EXPORT_SYMBOL_GPL(nvme_alloc_request);
I think nvme_alloc_request_qid needs to be exported as well.
FYI, this also doesn't apply to the current nvme-5.10 tree any more.
next prev parent reply other threads:[~2020-11-03 18:24 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-22 1:02 [PATCH V3 0/6] nvmet: passthru fixes and improvements Chaitanya Kulkarni
2020-10-22 1:02 ` [PATCH V3 1/6] nvme-core: add a helper to init req from nvme cmd Chaitanya Kulkarni
2020-10-22 1:02 ` [PATCH V3 2/6] nvme-core: split nvme_alloc_request() Chaitanya Kulkarni
2020-11-03 18:24 ` Christoph Hellwig [this message]
2020-11-04 21:03 ` Chaitanya Kulkarni
2020-10-22 1:02 ` [PATCH V3 3/6] nvmet: remove op_flags for passthru commands Chaitanya Kulkarni
2020-10-22 1:02 ` [PATCH V3 4/6] block: move blk_rq_bio_prep() to linux/blk-mq.h Chaitanya Kulkarni
2020-10-22 1:02 ` [PATCH V3 5/6] nvmet: use minimized version of blk_rq_append_bio Chaitanya Kulkarni
2020-10-22 1:02 ` [PATCH V3 6/6] nvmet: use inline bio for passthru fast path Chaitanya Kulkarni
2020-10-22 15:57 ` Logan Gunthorpe
2020-10-29 19:02 ` Chaitanya Kulkarni
2020-11-03 18:25 ` hch
2020-11-03 18:32 ` [PATCH V3 0/6] nvmet: passthru fixes and improvements Christoph Hellwig
2020-11-03 23:50 ` Chaitanya Kulkarni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201103182444.GA23300@lst.de \
--to=hch@lst.de \
--cc=chaitanya.kulkarni@wdc.com \
--cc=kbusch@kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=logang@deltatee.com \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).