From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1EE42C64E7C for ; Thu, 3 Dec 2020 01:28:28 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id BA54E22228 for ; Thu, 3 Dec 2020 01:28:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729059AbgLCB2U (ORCPT ); Wed, 2 Dec 2020 20:28:20 -0500 Received: from us-smtp-delivery-124.mimecast.com ([63.128.21.124]:53501 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726681AbgLCB2U (ORCPT ); Wed, 2 Dec 2020 20:28:20 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1606958814; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=0zSki3gxNEpgthjlkD9YwTOOCDdRqU6JTlx45o1EHwU=; b=Oc5PxJmdjnPPQKMYA7g33Z5uBu2LwcJ7T0+Yr/3ubcwgt4vgBCSb89zAqT3oGa9NalxYaD VoxbCIMeqmkOCGjjeV3uks/Cap3VNyC2ZXym9gv9dXt9L//iqyZlVOxxIPyJ8VEEuq20nA axLhbOHc2lPCQTYTfCBZCFTfSKzLVfk= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-396-9HFblrzVMu2TI4CbDMofEg-1; Wed, 02 Dec 2020 20:26:52 -0500 X-MC-Unique: 9HFblrzVMu2TI4CbDMofEg-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id F2B441005E79; Thu, 3 Dec 2020 01:26:50 +0000 (UTC) Received: from localhost (ovpn-12-87.pek2.redhat.com [10.72.12.87]) by smtp.corp.redhat.com (Postfix) with ESMTP id 3B5115C1BD; Thu, 3 Dec 2020 01:26:43 +0000 (UTC) From: Ming Lei To: Jens Axboe Cc: linux-block@vger.kernel.org, Ming Lei , Christoph Hellwig , Qian Cai , Sumit Saxena , John Garry , Kashyap Desai , Bart Van Assche , Hannes Reinecke Subject: [PATCH V2 0/3] blk-mq/nvme-loop: use nvme-loop's lock class for addressing lockdep false positive warning Date: Thu, 3 Dec 2020 09:26:35 +0800 Message-Id: <20201203012638.543321-1-ming.lei@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org Hi, Qian reported there is hang during booting when shared host tagset is introduced on megaraid sas. Sumit reported the whole SCSI probe takes about ~45min in his test. Turns out it is caused by nr_hw_queues increased, especially commit b3c6a5997541("block: Fix a lockdep complaint triggered by request queue flushing") adds synchronize_rcu() for each hctx's release handler. Address the original lockdep false positive warning by simpler way, then long scsi probe can be avoided with lockdep enabled. V2: - add reviewed-by - adjust commit log of patch 3 Ming Lei (3): blk-mq: add new API of blk_mq_hctx_set_fq_lock_class nvme-loop: use blk_mq_hctx_set_fq_lock_class to set loop's lock class Revert "block: Fix a lockdep complaint triggered by request queue flushing" block/blk-flush.c | 30 +++++++++++++++++++++++++----- block/blk.h | 1 - drivers/nvme/target/loop.c | 10 ++++++++++ include/linux/blk-mq.h | 3 +++ 4 files changed, 38 insertions(+), 6 deletions(-) Cc: Christoph Hellwig Cc: Qian Cai Cc: Sumit Saxena Cc: John Garry Cc: Kashyap Desai Cc: Bart Van Assche Cc: Hannes Reinecke -- 2.28.0