From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 23F18C433DB for ; Thu, 21 Jan 2021 13:01:05 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id CFC72239FF for ; Thu, 21 Jan 2021 13:01:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728970AbhAUNAn (ORCPT ); Thu, 21 Jan 2021 08:00:43 -0500 Received: from m12-14.163.com ([220.181.12.14]:48011 "EHLO m12-14.163.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729516AbhAUNAA (ORCPT ); Thu, 21 Jan 2021 08:00:00 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=163.com; s=s110527; h=From:Subject:Date:Message-Id; bh=FEdSHQ+VY9QSsQqqOi sGJNCqPdWCuaYg20onoC444ig=; b=L7JAkcxBw3NQbgfQrQQbjYKBW8UwDHFMdp kKGKYKsoM+9YWai8041JNiJyXtemYZDCtVGSKO+6+bW3TnUDQAiXG+8Qqih3W3GP dpEXwmIq4EG1Pfx8uvIHZG8CcsaLfEXUpDBd/QIcZlvq2qMqfrT3by7Ztqp6LtH/ jTNwlvTHw= Received: from localhost.localdomain (unknown [119.3.119.20]) by smtp10 (Coremail) with SMTP id DsCowAA3XoqjKwlg_aB8hA--.62335S4; Thu, 21 Jan 2021 15:22:15 +0800 (CST) From: Pan Bian To: Matias Bjorling , Jens Axboe Cc: linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, Pan Bian Subject: [PATCH] lightnvm: fix memory leak when submit fails Date: Wed, 20 Jan 2021 23:22:02 -0800 Message-Id: <20210121072202.120810-1-bianpan2016@163.com> X-Mailer: git-send-email 2.17.1 X-CM-TRANSID: DsCowAA3XoqjKwlg_aB8hA--.62335S4 X-Coremail-Antispam: 1Uf129KBjvdXoWrKF1kuFy7Cr47Xr4rXry5Arb_yoWfJrb_C3 WjvFs7AryrCay2qwn8t3W3Z3s29w4rWrsY9r4ftasxJryDXwnIyayYgr9Iqa4Yvr43ur9x GaykAF17uw1rtjkaLaAFLSUrUUUUUb8apTn2vfkv8UJUUUU8Yxn0WfASr-VFAUDa7-sFnT 9fnUUvcSsGvfC2KfnxnUUI43ZEXa7IU5_rc3UUUUU== X-Originating-IP: [119.3.119.20] X-CM-SenderInfo: held01tdqsiiqw6rljoofrz/xtbBzx4hclaD9zBl9gABsC Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org The allocated page is not released if error occurs in nvm_submit_io_sync_raw(). __free_page() is moved ealier to avoid possible memory leak issue. Fixes: aff3fb18f957 ("lightnvm: move bad block and chunk state logic to core") Signed-off-by: Pan Bian --- drivers/lightnvm/core.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/lightnvm/core.c b/drivers/lightnvm/core.c index c1bcac71008c..28ddcaa5358b 100644 --- a/drivers/lightnvm/core.c +++ b/drivers/lightnvm/core.c @@ -844,11 +844,10 @@ static int nvm_bb_chunk_sense(struct nvm_dev *dev, struct ppa_addr ppa) rqd.ppa_addr = generic_to_dev_addr(dev, ppa); ret = nvm_submit_io_sync_raw(dev, &rqd); + __free_page(page); if (ret) return ret; - __free_page(page); - return rqd.error; } -- 2.17.1