linux-block.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Javier González" <javier@javigon.com>
To: Jens Axboe <axboe@kernel.dk>
Cc: Pan Bian <bianpan2016@163.com>, Matias Bjorling <mb@lightnvm.io>,
	linux-block@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] lightnvm: fix memory leak when submit fails
Date: Thu, 21 Jan 2021 14:28:46 +0100	[thread overview]
Message-ID: <20210121132846.4t4ijlogfi2pndpf@mpHalley.local> (raw)
In-Reply-To: <55045608-01cb-d5af-682b-5a213944e33d@kernel.dk>

On 21.01.2021 05:47, Jens Axboe wrote:
>On 1/21/21 12:22 AM, Pan Bian wrote:
>> The allocated page is not released if error occurs in
>> nvm_submit_io_sync_raw(). __free_page() is moved ealier to avoid
>> possible memory leak issue.
>
>Applied, thanks.
>
>General question for Matias - is lightnvm maintained anymore at all, or
>should we remove it? The project seems dead from my pov, and I don't
>even remember anyone even reviewing fixes from other people.
>

At least from the pblk side, I have no objections to removing it. I test
briefly that pblk runs on new releases, but there are no new features or
known bug fixes coming in.

Current deployments - to the best of my knowledge - are forks, which are
not being retrofitted upstream.

For completeness, I get a number of questions and request primarily from
the academia. These people will probably accuse the lack of LightNVM. I
understand though that this is not an argument to keep it.

Javier

  reply	other threads:[~2021-01-21 13:30 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-21  7:22 [PATCH] lightnvm: fix memory leak when submit fails Pan Bian
2021-01-21 12:47 ` Jens Axboe
2021-01-21 13:28   ` Javier González [this message]
2021-01-21 13:55   ` Matias Bjørling
2021-01-21 16:58     ` Heiner Litz
2021-01-21 18:25       ` Matias Bjørling
2021-01-21 19:49         ` Heiner Litz
2021-01-21 20:14           ` Matias Bjørling
2021-01-21 23:20             ` Heiner Litz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210121132846.4t4ijlogfi2pndpf@mpHalley.local \
    --to=javier@javigon.com \
    --cc=axboe@kernel.dk \
    --cc=bianpan2016@163.com \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mb@lightnvm.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).