From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 52C58C4332D for ; Thu, 28 Jan 2021 09:29:33 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 997B464DE6 for ; Thu, 28 Jan 2021 09:29:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232443AbhA1JVC (ORCPT ); Thu, 28 Jan 2021 04:21:02 -0500 Received: from verein.lst.de ([213.95.11.211]:56588 "EHLO verein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232476AbhA1JR4 (ORCPT ); Thu, 28 Jan 2021 04:17:56 -0500 Received: by verein.lst.de (Postfix, from userid 2407) id 51C6868AFE; Thu, 28 Jan 2021 10:17:10 +0100 (CET) Date: Thu, 28 Jan 2021 10:17:10 +0100 From: Christoph Hellwig To: Damien Le Moal Cc: linux-block@vger.kernel.org, Jens Axboe , linux-scsi@vger.kernel.org, "Martin K . Petersen" , linux-nvme@lists.infradead.org, Christoph Hellwig , Keith Busch , Chaitanya Kulkarni Subject: Re: [PATCH v4 2/8] nvme: cleanup zone information initialization Message-ID: <20210128091710.GA1959@lst.de> References: <20210128044733.503606-1-damien.lemoal@wdc.com> <20210128044733.503606-3-damien.lemoal@wdc.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210128044733.503606-3-damien.lemoal@wdc.com> User-Agent: Mutt/1.5.17 (2007-11-01) Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org > int nvme_revalidate_zones(struct nvme_ns *ns) > { > - struct request_queue *q = ns->queue; > - int ret; > - > - ret = blk_revalidate_disk_zones(ns->disk, NULL); > - if (!ret) > - blk_queue_max_zone_append_sectors(q, ns->ctrl->max_zone_append); > - return ret; > + return blk_revalidate_disk_zones(ns->disk, NULL); We can just kill off nvme_revalidate_zones now and open code it in the caller as the stub is no needed now that blk_queue_is_zoned always return false for the !CONFIG_BLK_DEV_ZONED case. Otherwise this look great, nice cleanup: Reviewed-by: Christoph Hellwig