From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5A0C9C433E9 for ; Thu, 28 Jan 2021 09:21:29 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1E44C64DD8 for ; Thu, 28 Jan 2021 09:21:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232452AbhA1JVG (ORCPT ); Thu, 28 Jan 2021 04:21:06 -0500 Received: from verein.lst.de ([213.95.11.211]:56594 "EHLO verein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232480AbhA1JSK (ORCPT ); Thu, 28 Jan 2021 04:18:10 -0500 Received: by verein.lst.de (Postfix, from userid 2407) id 480C468B02; Thu, 28 Jan 2021 10:17:27 +0100 (CET) Date: Thu, 28 Jan 2021 10:17:27 +0100 From: Christoph Hellwig To: Damien Le Moal Cc: linux-block@vger.kernel.org, Jens Axboe , linux-scsi@vger.kernel.org, "Martin K . Petersen" , linux-nvme@lists.infradead.org, Christoph Hellwig , Keith Busch , Chaitanya Kulkarni Subject: Re: [PATCH v4 3/8] nullb: use blk_queue_set_zoned() to setup zoned devices Message-ID: <20210128091727.GB1959@lst.de> References: <20210128044733.503606-1-damien.lemoal@wdc.com> <20210128044733.503606-4-damien.lemoal@wdc.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210128044733.503606-4-damien.lemoal@wdc.com> User-Agent: Mutt/1.5.17 (2007-11-01) Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org On Thu, Jan 28, 2021 at 01:47:28PM +0900, Damien Le Moal wrote: > Use blk_queue_set_zoned() to set a nullb device zone model instead of > directly assigning the device queue zoned limit. This initialization of > the devicve zoned model as well as the setup of the queue flag > QUEUE_FLAG_ZONE_RESETALL and of the device queue elevator feature are > moved from null_init_zoned_dev() to null_register_zoned_dev() so that > the initialization of the queue limits is done when the gendisk of the > nullb device is available. Looks good, Reviewed-by: Christoph Hellwig