linux-block.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] uapi: fix comment about block device ioctl
@ 2021-03-16  1:17 Damien Le Moal
  2021-03-16 23:40 ` Chaitanya Kulkarni
                   ` (2 more replies)
  0 siblings, 3 replies; 4+ messages in thread
From: Damien Le Moal @ 2021-03-16  1:17 UTC (permalink / raw)
  To: Alexander Viro, linux-fsdevel, linux-block

Fix the comment mentioning ioctl command range used for zoned block
devices to reflect the range of commands actually implemented.

Signed-off-by: Damien Le Moal <damien.lemoal@wdc.com>
---
 include/uapi/linux/fs.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/include/uapi/linux/fs.h b/include/uapi/linux/fs.h
index f44eb0a04afd..4c32e97dcdf0 100644
--- a/include/uapi/linux/fs.h
+++ b/include/uapi/linux/fs.h
@@ -185,7 +185,7 @@ struct fsxattr {
 #define BLKROTATIONAL _IO(0x12,126)
 #define BLKZEROOUT _IO(0x12,127)
 /*
- * A jump here: 130-131 are reserved for zoned block devices
+ * A jump here: 130-136 are reserved for zoned block devices
  * (see uapi/linux/blkzoned.h)
  */
 
-- 
2.30.2


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH] uapi: fix comment about block device ioctl
  2021-03-16  1:17 [PATCH] uapi: fix comment about block device ioctl Damien Le Moal
@ 2021-03-16 23:40 ` Chaitanya Kulkarni
  2021-04-07 12:39 ` Damien Le Moal
  2021-04-08 16:27 ` Jens Axboe
  2 siblings, 0 replies; 4+ messages in thread
From: Chaitanya Kulkarni @ 2021-03-16 23:40 UTC (permalink / raw)
  To: Damien Le Moal, Alexander Viro, linux-fsdevel, linux-block

On 3/15/21 18:18, Damien Le Moal wrote:
> Fix the comment mentioning ioctl command range used for zoned block
> devices to reflect the range of commands actually implemented.
>
> Signed-off-by: Damien Le Moal <damien.lemoal@wdc.com>

I've verified that blkzoned.h contains the IOCTLs in the range of
130 - 136 in uapi/linux/blkzoned.h.

Looks good.

Reviewed-by: Chaitanya Kulkarni <chaitanya.kulkarni@wdc.com>


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] uapi: fix comment about block device ioctl
  2021-03-16  1:17 [PATCH] uapi: fix comment about block device ioctl Damien Le Moal
  2021-03-16 23:40 ` Chaitanya Kulkarni
@ 2021-04-07 12:39 ` Damien Le Moal
  2021-04-08 16:27 ` Jens Axboe
  2 siblings, 0 replies; 4+ messages in thread
From: Damien Le Moal @ 2021-04-07 12:39 UTC (permalink / raw)
  To: Alexander Viro, linux-fsdevel, linux-block, Jens Axboe

On 2021/03/16 10:18, Damien Le Moal wrote:
> Fix the comment mentioning ioctl command range used for zoned block
> devices to reflect the range of commands actually implemented.
> 
> Signed-off-by: Damien Le Moal <damien.lemoal@wdc.com>
> ---
>  include/uapi/linux/fs.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/include/uapi/linux/fs.h b/include/uapi/linux/fs.h
> index f44eb0a04afd..4c32e97dcdf0 100644
> --- a/include/uapi/linux/fs.h
> +++ b/include/uapi/linux/fs.h
> @@ -185,7 +185,7 @@ struct fsxattr {
>  #define BLKROTATIONAL _IO(0x12,126)
>  #define BLKZEROOUT _IO(0x12,127)
>  /*
> - * A jump here: 130-131 are reserved for zoned block devices
> + * A jump here: 130-136 are reserved for zoned block devices
>   * (see uapi/linux/blkzoned.h)
>   */

Al,

Ping ?
Can you take this or should it go through the blok tree ?


-- 
Damien Le Moal
Western Digital Research

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] uapi: fix comment about block device ioctl
  2021-03-16  1:17 [PATCH] uapi: fix comment about block device ioctl Damien Le Moal
  2021-03-16 23:40 ` Chaitanya Kulkarni
  2021-04-07 12:39 ` Damien Le Moal
@ 2021-04-08 16:27 ` Jens Axboe
  2 siblings, 0 replies; 4+ messages in thread
From: Jens Axboe @ 2021-04-08 16:27 UTC (permalink / raw)
  To: Damien Le Moal, Alexander Viro, linux-fsdevel, linux-block

On 3/15/21 7:17 PM, Damien Le Moal wrote:
> Fix the comment mentioning ioctl command range used for zoned block
> devices to reflect the range of commands actually implemented.

Reviewed-by: Jens Axboe <axboe@kernel.dk>

-- 
Jens Axboe


^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2021-04-08 16:27 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-03-16  1:17 [PATCH] uapi: fix comment about block device ioctl Damien Le Moal
2021-03-16 23:40 ` Chaitanya Kulkarni
2021-04-07 12:39 ` Damien Le Moal
2021-04-08 16:27 ` Jens Axboe

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).