linux-block.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* start removing block bounce buffering support
@ 2021-03-18  6:39 Christoph Hellwig
  2021-03-18  6:39 ` [PATCH 1/8] aha1542: use a local bounce buffer Christoph Hellwig
                   ` (7 more replies)
  0 siblings, 8 replies; 24+ messages in thread
From: Christoph Hellwig @ 2021-03-18  6:39 UTC (permalink / raw)
  To: Jens Axboe, Khalid Aziz, Martin K. Petersen, Matthew Wilcox,
	Hannes Reinecke, Ondrej Zary
  Cc: linux-block, linux-scsi

Hi all,

this series starts to clean up and remove the impact of the legacy old
block layer bounce buffering code.

First it removes support for ISA bouncing.  This was used by three SCSI
drivers.  One of them actually had an active user and developer 5 years
ago so I've converted it to use a local bounce buffer - Ondrej, can you
test the coversion?  The next one has been known broken for years, and
the third one looks like it has no users for the ISA support so they
are just dropped.

It then removes support for dealing with bounce buffering highmem pages
for passthrough requests as we can just use the copy instead of the map
path for them.  This will reduce efficiency for such setups on highmem
systems (e.g. usb-storage attached DVD drives), but then again that is
what you get for using a driver not using modern interfaces on a 32-bit
highmem system.  It does allow to streamline the common path pretty nicely.

Diffstat:
 Documentation/scsi/scsi_mid_low_api.rst |    4 
 block/bio-integrity.c                   |    3 
 block/blk-core.c                        |    6 
 block/blk-map.c                         |  120 +++----------
 block/blk-settings.c                    |   53 ------
 block/blk.h                             |   17 +
 block/bounce.c                          |  138 ++-------------
 block/scsi_ioctl.c                      |    2 
 drivers/ata/libata-scsi.c               |    3 
 drivers/nvme/host/lightnvm.c            |    2 
 drivers/scsi/BusLogic.c                 |  177 +-------------------
 drivers/scsi/BusLogic.h                 |    4 
 drivers/scsi/Kconfig                    |    2 
 drivers/scsi/advansys.c                 |  279 ++------------------------------
 drivers/scsi/aha1542.c                  |  105 ++++++------
 drivers/scsi/esas2r/esas2r_main.c       |    1 
 drivers/scsi/hosts.c                    |    7 
 drivers/scsi/scsi_debugfs.c             |    1 
 drivers/scsi/scsi_lib.c                 |   52 -----
 drivers/scsi/scsi_scan.c                |    6 
 drivers/scsi/scsi_sysfs.c               |    2 
 drivers/scsi/sg.c                       |   10 -
 drivers/scsi/sr_ioctl.c                 |   12 -
 drivers/scsi/st.c                       |   20 --
 drivers/scsi/st.h                       |    2 
 drivers/target/target_core_pscsi.c      |    4 
 include/linux/blkdev.h                  |   38 +---
 include/scsi/scsi_cmnd.h                |    7 
 include/scsi/scsi_host.h                |    6 
 mm/Kconfig                              |    9 -
 30 files changed, 210 insertions(+), 882 deletions(-)

^ permalink raw reply	[flat|nested] 24+ messages in thread
* start removing block bounce buffering support v2
@ 2021-03-26  5:58 Christoph Hellwig
  2021-03-26  5:58 ` [PATCH 5/8] scsi: remove the unchecked_isa_dma flag Christoph Hellwig
  0 siblings, 1 reply; 24+ messages in thread
From: Christoph Hellwig @ 2021-03-26  5:58 UTC (permalink / raw)
  To: Jens Axboe, Khalid Aziz, Martin K. Petersen, Matthew Wilcox,
	Hannes Reinecke, Ondrej Zary
  Cc: linux-block, linux-scsi

Hi all,

this series starts to clean up and remove the impact of the legacy old
block layer bounce buffering code.

First it removes support for ISA bouncing.  This was used by three SCSI
drivers.  One of them actually had an active user and developer 5 years
ago so I've converted it to use a local bounce buffer - Ondrej, can you
test the coversion?  The next one has been known broken for years, and
the third one looks like it has no users for the ISA support so they
are just dropped.

It then removes support for dealing with bounce buffering highmem pages
for passthrough requests as we can just use the copy instead of the map
path for them.  This will reduce efficiency for such setups on highmem
systems (e.g. usb-storage attached DVD drives), but then again that is
what you get for using a driver not using modern interfaces on a 32-bit
highmem system.  It does allow to streamline the common path pretty nicely.


Changes since v1:
 - remove more dead code in advansys.c
 - fix the bounce limit stacking in blk_stack_limits

^ permalink raw reply	[flat|nested] 24+ messages in thread
* start removing block bounce buffering support v3
@ 2021-03-31  7:29 Christoph Hellwig
  2021-03-31  7:29 ` [PATCH 5/8] scsi: remove the unchecked_isa_dma flag Christoph Hellwig
  0 siblings, 1 reply; 24+ messages in thread
From: Christoph Hellwig @ 2021-03-31  7:29 UTC (permalink / raw)
  To: Jens Axboe, Khalid Aziz, Martin K. Petersen, Matthew Wilcox,
	Hannes Reinecke, Ondrej Zary
  Cc: linux-block, linux-scsi

Hi all,

this series starts to clean up and remove the impact of the legacy old
block layer bounce buffering code.

First it removes support for ISA bouncing.  This was used by three SCSI
drivers.  One of them actually had an active user and developer 5 years
ago so I've converted it to use a local bounce buffer - Ondrej, can you
test the coversion?  The next one has been known broken for years, and
the third one looks like it has no users for the ISA support so they
are just dropped.

It then removes support for dealing with bounce buffering highmem pages
for passthrough requests as we can just use the copy instead of the map
path for them.  This will reduce efficiency for such setups on highmem
systems (e.g. usb-storage attached DVD drives), but then again that is
what you get for using a driver not using modern interfaces on a 32-bit
highmem system.  It does allow to streamline the common path pretty nicely.


Changes since v2:
 - remove more dead code in advansys.c
 - remove more dead code in BusLogic.c
 - update the BusLogic documentation

Changes since v1:
 - remove more dead code in advansys.c
 - fix the bounce limit stacking in blk_stack_limits

^ permalink raw reply	[flat|nested] 24+ messages in thread

end of thread, other threads:[~2021-04-12 14:04 UTC | newest]

Thread overview: 24+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-03-18  6:39 start removing block bounce buffering support Christoph Hellwig
2021-03-18  6:39 ` [PATCH 1/8] aha1542: use a local bounce buffer Christoph Hellwig
2021-03-18  6:39 ` [PATCH 2/8] Buslogic: remove ISA support Christoph Hellwig
2021-03-18  6:39 ` [PATCH 3/8] BusLogic: reject broken old firmware that requires ISA-style bounce buffering Christoph Hellwig
2021-03-18  6:39 ` [PATCH 4/8] advansys: remove ISA support Christoph Hellwig
2021-03-18 11:20   ` Matthew Wilcox
2021-03-18 12:54     ` Christoph Hellwig
2021-03-18 14:34       ` Matthew Wilcox
2021-03-18  6:39 ` [PATCH 5/8] scsi: remove the unchecked_isa_dma flag Christoph Hellwig
2021-03-18  6:39 ` [PATCH 6/8] block: remove BLK_BOUNCE_ISA support Christoph Hellwig
2021-03-18  6:39 ` [PATCH 7/8] block: refactor the bounce buffering code Christoph Hellwig
2021-03-18 11:29   ` Matthew Wilcox
2021-03-18 12:53     ` Christoph Hellwig
2021-03-24 17:40       ` Benjamin Block
2021-03-24 17:44         ` Christoph Hellwig
2021-03-24 18:07           ` Benjamin Block
2021-03-24 18:13             ` Christoph Hellwig
2021-03-18  6:39 ` [PATCH 8/8] block: stop calling blk_queue_bounce for passthrough requests Christoph Hellwig
2021-03-26  5:58 start removing block bounce buffering support v2 Christoph Hellwig
2021-03-26  5:58 ` [PATCH 5/8] scsi: remove the unchecked_isa_dma flag Christoph Hellwig
2021-03-29  6:31   ` Hannes Reinecke
2021-03-31  7:29 start removing block bounce buffering support v3 Christoph Hellwig
2021-03-31  7:29 ` [PATCH 5/8] scsi: remove the unchecked_isa_dma flag Christoph Hellwig
2021-04-09 15:46   ` Steffen Maier
2021-04-10  6:52     ` Christoph Hellwig
2021-04-12 14:04       ` Steffen Maier

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).