linux-block.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Matthew Wilcox <willy@infradead.org>
To: Christoph Hellwig <hch@lst.de>
Cc: Jens Axboe <axboe@kernel.dk>, Khalid Aziz <khalid@gonehiking.org>,
	"Martin K. Petersen" <martin.petersen@oracle.com>,
	Hannes Reinecke <hare@suse.com>,
	Ondrej Zary <linux@rainbow-software.org>,
	linux-block@vger.kernel.org, linux-scsi@vger.kernel.org
Subject: Re: [PATCH 4/8] advansys: remove ISA support
Date: Thu, 18 Mar 2021 14:34:09 +0000	[thread overview]
Message-ID: <20210318143409.GN3420@casper.infradead.org> (raw)
In-Reply-To: <20210318125453.GB21262@lst.de>

On Thu, Mar 18, 2021 at 01:54:53PM +0100, Christoph Hellwig wrote:
> On Thu, Mar 18, 2021 at 11:20:25AM +0000, Matthew Wilcox wrote:
> > On Thu, Mar 18, 2021 at 07:39:19AM +0100, Christoph Hellwig wrote:
> > > @@ -2875,7 +2859,6 @@ static void asc_prt_asc_board_eeprom(struct seq_file *m, struct Scsi_Host *shost
> > >  	uchar serialstr[13];
> > >  #ifdef CONFIG_ISA
> > >  	ASC_DVC_VAR *asc_dvc_varp;
> > > -	int isa_dma_speed[] = { 10, 8, 7, 6, 5, 4, 3, 2 };
> > >  
> > >  	asc_dvc_varp = &boardp->dvc_var.asc_dvc_var;
> > >  #endif /* CONFIG_ISA */
> > 
> > I think you can remove the conditional definition & assignment of
> > asc_dvc_varp here.
> 
> The way I read the driver CONFIG_ISA also covers Vesa Local Bus
> support, which is not removed by this patch.  Corret me if I'm wrong.

I agree that VLB is also enabled by CONFIG_ISA in this driver,
but in this specific function, I think you removed the only use
of asc_dvc_varp.

  reply	other threads:[~2021-03-18 14:36 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-18  6:39 start removing block bounce buffering support Christoph Hellwig
2021-03-18  6:39 ` [PATCH 1/8] aha1542: use a local bounce buffer Christoph Hellwig
2021-03-18  6:39 ` [PATCH 2/8] Buslogic: remove ISA support Christoph Hellwig
2021-03-18  6:39 ` [PATCH 3/8] BusLogic: reject broken old firmware that requires ISA-style bounce buffering Christoph Hellwig
2021-03-18  6:39 ` [PATCH 4/8] advansys: remove ISA support Christoph Hellwig
2021-03-18 11:20   ` Matthew Wilcox
2021-03-18 12:54     ` Christoph Hellwig
2021-03-18 14:34       ` Matthew Wilcox [this message]
2021-03-18  6:39 ` [PATCH 5/8] scsi: remove the unchecked_isa_dma flag Christoph Hellwig
2021-03-18  6:39 ` [PATCH 6/8] block: remove BLK_BOUNCE_ISA support Christoph Hellwig
2021-03-18  6:39 ` [PATCH 7/8] block: refactor the bounce buffering code Christoph Hellwig
2021-03-18 11:29   ` Matthew Wilcox
2021-03-18 12:53     ` Christoph Hellwig
2021-03-24 17:40       ` Benjamin Block
2021-03-24 17:44         ` Christoph Hellwig
2021-03-24 18:07           ` Benjamin Block
2021-03-24 18:13             ` Christoph Hellwig
2021-03-18  6:39 ` [PATCH 8/8] block: stop calling blk_queue_bounce for passthrough requests Christoph Hellwig
2021-03-26  5:58 start removing block bounce buffering support v2 Christoph Hellwig
2021-03-26  5:58 ` [PATCH 4/8] advansys: remove ISA support Christoph Hellwig
2021-03-29  6:31   ` Hannes Reinecke
2021-03-30 17:26     ` Christoph Hellwig
2021-03-31  7:29 start removing block bounce buffering support v3 Christoph Hellwig
2021-03-31  7:29 ` [PATCH 4/8] advansys: remove ISA support Christoph Hellwig
2021-03-31  7:59   ` Hannes Reinecke

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210318143409.GN3420@casper.infradead.org \
    --to=willy@infradead.org \
    --cc=axboe@kernel.dk \
    --cc=hare@suse.com \
    --cc=hch@lst.de \
    --cc=khalid@gonehiking.org \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=linux@rainbow-software.org \
    --cc=martin.petersen@oracle.com \
    --subject='Re: [PATCH 4/8] advansys: remove ISA support' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
on how to clone and mirror all data and code used for this inbox