From: Minwoo Im <minwoo.im.dev@gmail.com>
To: Niklas Cassel <Niklas.Cassel@wdc.com>
Cc: "javier@javigon.com" <javier@javigon.com>,
"linux-nvme@lists.infradead.org" <linux-nvme@lists.infradead.org>,
"sagi@grimberg.me" <sagi@grimberg.me>,
"linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
"kbusch@kernel.org" <kbusch@kernel.org>,
"Javier González" <javier.gonz@samsung.com>,
"hch@lst.de" <hch@lst.de>
Subject: Re: [PATCH V6 1/2] nvme: enable char device per namespace
Date: Thu, 25 Mar 2021 21:33:29 +0900 [thread overview]
Message-ID: <20210325123329.GA3850@localhost> (raw)
In-Reply-To: <YFyBM1qq+AmYQvdl@x1-carbon.lan>
On 21-03-25 12:25:24, Niklas Cassel wrote:
> On Mon, Mar 01, 2021 at 08:24:51PM +0100, javier@javigon.com wrote:
> > From: Javier González <javier.gonz@samsung.com>
> >
> > Create a char device per NVMe namespace. This char device is always
> > initialized, independently of whether the features implemented by the
> > device are supported by the kernel. User-space can therefore always
> > issue IOCTLs to the NVMe driver using the char device.
> >
> > The char device is presented as /dev/nvme-generic-XcYnZ. This naming
> > scheme follows the convention of the hidden device (nvmeXcYnZ). Support
> > for multipath will follow.
>
> Do we perhaps want to put these new character devices inside a subdir?
> e.g. /dev/nvme/nvme-generic-XcYnZ ?
>
> Otherwise it feels like doing such a simple thing as ls -al /dev/nvme*
> will show a lot of devices because of these new specialized char devices.
Good point. If we have thousands of namespaces, it will create 2 times
of the blkdevs. I would hear what maintainers say about this :)
FYI: new version has been posted with V1 by re-create this series with
Javier. Please have a discuss there:
https://lore.kernel.org/linux-nvme/20210325123048.94784-1-minwoo.im.dev@gmail.com/T/#u
Thanks!
>
>
> Kind regards,
> Niklas
next prev parent reply other threads:[~2021-03-25 12:34 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-01 19:24 [PATCH V6 0/2] nvme: enable char device per namespace javier
2021-03-01 19:24 ` [PATCH V6 1/2] " javier
2021-03-03 9:10 ` Christoph Hellwig
2021-03-03 10:02 ` Javier González
2021-03-09 11:31 ` Christoph Hellwig
2021-03-09 12:42 ` Javier González
2021-03-09 15:05 ` Christoph Hellwig
2021-03-09 21:18 ` Javier González
2021-03-24 12:29 ` Niklas Cassel
2021-03-25 2:09 ` Minwoo Im
2021-03-25 8:26 ` hch
2021-03-25 8:39 ` Niklas Cassel
2021-03-25 9:34 ` Minwoo Im
2021-03-25 12:25 ` Niklas Cassel
2021-03-25 12:33 ` Minwoo Im [this message]
2021-03-25 15:14 ` Keith Busch
2021-03-01 19:24 ` [PATCH V6 2/2] nvme: allow open for nvme-generic char device javier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210325123329.GA3850@localhost \
--to=minwoo.im.dev@gmail.com \
--cc=Niklas.Cassel@wdc.com \
--cc=hch@lst.de \
--cc=javier.gonz@samsung.com \
--cc=javier@javigon.com \
--cc=kbusch@kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).