From: Gioh Kim <gi-oh.kim@ionos.com>
To: linux-block@vger.kernel.org
Cc: axboe@kernel.dk, hch@infradead.org, sagi@grimberg.me,
bvanassche@acm.org, haris.iqbal@ionos.com, jinpu.wang@ionos.com,
Gioh Kim <gi-oh.kim@cloud.ionos.com>,
Gioh Kim <gi-oh.kim@ionos.com>
Subject: [PATCHv2 for-next 17/24] block/rnbd-clt: Fix missing a memory free when unloading the module
Date: Tue, 30 Mar 2021 09:37:45 +0200 [thread overview]
Message-ID: <20210330073752.1465613-18-gi-oh.kim@ionos.com> (raw)
In-Reply-To: <20210330073752.1465613-1-gi-oh.kim@ionos.com>
From: Gioh Kim <gi-oh.kim@cloud.ionos.com>
When unloading the rnbd-clt module, it does not free a memory
including the filename of the symbolic link to /sys/block/rnbdX.
It is found by kmemleak as below.
unreferenced object 0xffff9f1a83d3c740 (size 16):
comm "bash", pid 736, jiffies 4295179665 (age 9841.310s)
hex dump (first 16 bytes):
21 64 65 76 21 6e 75 6c 6c 62 30 40 62 6c 61 00 !dev!nullb0@bla.
backtrace:
[<0000000039f0c55e>] 0xffffffffc0456c24
[<000000001aab9513>] kernfs_fop_write+0xcf/0x1c0
[<00000000db5aa4b3>] vfs_write+0xdb/0x1d0
[<000000007a2e2207>] ksys_write+0x65/0xe0
[<00000000055e280a>] do_syscall_64+0x50/0x1b0
[<00000000c2b51831>] entry_SYSCALL_64_after_hwframe+0x49/0xbe
Signed-off-by: Gioh Kim <gi-oh.kim@ionos.com>
Signed-off-by: Jack Wang <jinpu.wang@ionos.com>
---
drivers/block/rnbd/rnbd-clt-sysfs.c | 10 +++++++---
1 file changed, 7 insertions(+), 3 deletions(-)
diff --git a/drivers/block/rnbd/rnbd-clt-sysfs.c b/drivers/block/rnbd/rnbd-clt-sysfs.c
index 2452eb67547c..885074f2f734 100644
--- a/drivers/block/rnbd/rnbd-clt-sysfs.c
+++ b/drivers/block/rnbd/rnbd-clt-sysfs.c
@@ -432,10 +432,14 @@ void rnbd_clt_remove_dev_symlink(struct rnbd_clt_dev *dev)
* i.e. rnbd_clt_unmap_dev_store() leading to a sysfs warning because
* of sysfs link already was removed already.
*/
- if (dev->blk_symlink_name && try_module_get(THIS_MODULE)) {
- sysfs_remove_link(rnbd_devs_kobj, dev->blk_symlink_name);
+ if (dev->blk_symlink_name) {
+ if (try_module_get(THIS_MODULE)) {
+ sysfs_remove_link(rnbd_devs_kobj, dev->blk_symlink_name);
+ module_put(THIS_MODULE);
+ }
+ /* It should be freed always. */
kfree(dev->blk_symlink_name);
- module_put(THIS_MODULE);
+ dev->blk_symlink_name = NULL;
}
}
--
2.25.1
next prev parent reply other threads:[~2021-03-30 7:39 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-30 7:37 [PATCHv2 for-next 00/24] Misc update for rnbd Gioh Kim
2021-03-30 7:37 ` [PATCHv2 for-next 01/24] MAINTAINERS: Change maintainer for rnbd module Gioh Kim
2021-03-30 7:37 ` [PATCHv2 for-next 02/24] Documentation/sysfs-block-rnbd: Add descriptions for remap_device and resize Gioh Kim
2021-03-30 7:37 ` [PATCHv2 for-next 03/24] block/rnbd: Enable the fault-injection Gioh Kim
2021-03-30 7:37 ` [PATCHv2 for-next 04/24] block/rnbd-srv: Inject a fault at bio processing Gioh Kim
2021-03-30 7:37 ` [PATCHv2 for-next 05/24] block/rnbd-clt: Inject some fault points Gioh Kim
2021-03-30 7:37 ` [PATCHv2 for-next 06/24] docs: fault-injection: Add fault-injection manual of RNBD Gioh Kim
2021-03-30 7:37 ` [PATCHv2 for-next 07/24] docs: Add RTRS/RNBD to the index of fault-injection Gioh Kim
2021-03-30 7:37 ` [PATCHv2 for-next 08/24] block/rnbd-clt: Remove some arguments from insert_dev_if_not_exists_devpath Gioh Kim
2021-03-30 23:50 ` Chaitanya Kulkarni
2021-03-30 7:37 ` [PATCHv2 for-next 09/24] block/rnbd-clt: Remove some arguments from rnbd_client_setup_device Gioh Kim
2021-03-30 23:51 ` Chaitanya Kulkarni
2021-03-30 7:37 ` [PATCHv2 for-next 10/24] block/rnbd-clt: Move add_disk(dev->gd) to rnbd_clt_setup_gen_disk Gioh Kim
2021-03-30 23:55 ` Chaitanya Kulkarni
2021-03-31 6:32 ` Gioh Kim
2021-03-30 7:37 ` [PATCHv2 for-next 11/24] block/rnbd: Kill rnbd_clt_destroy_default_group Gioh Kim
2021-03-30 23:56 ` Chaitanya Kulkarni
2021-03-30 7:37 ` [PATCHv2 for-next 12/24] block/rnbd: Kill destroy_device_cb Gioh Kim
2021-03-30 23:56 ` Chaitanya Kulkarni
2021-03-30 7:37 ` [PATCHv2 for-next 13/24] block/rnbd-clt: Replace {NO_WAIT,WAIT} with RTRS_PERMIT_{WAIT,NOWAIT} Gioh Kim
2021-03-31 0:01 ` Chaitanya Kulkarni
2021-03-30 7:37 ` [PATCHv2 for-next 14/24] block/rnbd-srv: Prevent a deadlock generated by accessing sysfs in parallel Gioh Kim
2021-03-30 7:37 ` [PATCHv2 for-next 15/24] block/rnbd-srv: Remove force_close file after holding a lock Gioh Kim
2021-03-30 7:37 ` [PATCHv2 for-next 16/24] block/rnbd-clt: Improve find_or_create_sess() return check Gioh Kim
2021-03-30 7:37 ` Gioh Kim [this message]
2021-03-30 7:37 ` [PATCHv2 for-next 18/24] block/rnbd-clt: Support polling mode for IO latency optimization Gioh Kim
2021-03-30 7:37 ` [PATCHv2 for-next 19/24] Documentation/ABI/rnbd-clt: Add description for nr_poll_queues Gioh Kim
2021-03-30 7:37 ` [PATCHv2 for-next 20/24] block/rnbd-srv: Remove unused arguments of rnbd_srv_rdma_ev Gioh Kim
2021-03-31 0:07 ` Chaitanya Kulkarni
2021-03-30 7:37 ` [PATCHv2 for-next 21/24] block/rnbd-clt: Generate kobject_uevent when the rnbd device state changes Gioh Kim
2021-03-30 7:37 ` [PATCHv2 for-next 22/24] block/rnbd-clt: Remove max_segment_size Gioh Kim
2021-03-30 7:37 ` [PATCHv2 for-next 23/24] block/rnbd-clt-sysfs: Remove copy buffer overlap in rnbd_clt_get_path_name Gioh Kim
2021-03-31 0:08 ` Chaitanya Kulkarni
2021-03-30 7:37 ` [PATCHv2 for-next 24/24] block/rnbd: Use strscpy instead of strlcpy Gioh Kim
2021-03-31 0:09 ` Chaitanya Kulkarni
2021-04-01 19:22 ` [PATCHv2 for-next 00/24] Misc update for rnbd Jason Gunthorpe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210330073752.1465613-18-gi-oh.kim@ionos.com \
--to=gi-oh.kim@ionos.com \
--cc=axboe@kernel.dk \
--cc=bvanassche@acm.org \
--cc=gi-oh.kim@cloud.ionos.com \
--cc=haris.iqbal@ionos.com \
--cc=hch@infradead.org \
--cc=jinpu.wang@ionos.com \
--cc=linux-block@vger.kernel.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).