From: Christoph Hellwig <hch@lst.de>
To: Khalid Aziz <khalid@gonehiking.org>
Cc: Christoph Hellwig <hch@lst.de>, Jens Axboe <axboe@kernel.dk>,
"Martin K. Petersen" <martin.petersen@oracle.com>,
Matthew Wilcox <willy@infradead.org>,
Hannes Reinecke <hare@suse.com>,
Ondrej Zary <linux@rainbow-software.org>,
linux-block@vger.kernel.org, linux-scsi@vger.kernel.org
Subject: Re: [PATCH 2/8] Buslogic: remove ISA support
Date: Tue, 30 Mar 2021 19:03:20 +0200 [thread overview]
Message-ID: <20210330170320.GC13829@lst.de> (raw)
In-Reply-To: <90427abe-f0a3-c6fc-a674-7a3967e20882@gonehiking.org>
On Mon, Mar 29, 2021 at 02:29:21PM -0600, Khalid Aziz wrote:
> On 3/25/21 11:58 PM, Christoph Hellwig wrote:
> > The ISA support in Buslogic has been broken for a long time, as all
> > the I/O path expects a struct device for DMA mapping that is derived from
> > the PCI device, which would simply crash for ISA adapters.
> >
> > Signed-off-by: Christoph Hellwig <hch@lst.de>
> > ---
> > drivers/scsi/BusLogic.c | 156 ++--------------------------------------
> > drivers/scsi/BusLogic.h | 3 -
> > drivers/scsi/Kconfig | 2 +-
> > 3 files changed, 6 insertions(+), 155 deletions(-)
> >
>
> Hi Chris,
>
> This looks good. There is more code that can be removed, for instance
> all of the code that supports "IO:" driver option to specify ISA port
> addresses. enum blogic_adapter_bus_type can shrink. "limited_isa" and
> "probe*" members of struct blogic_probe_options can go away. You could
> add those to this patch, or if you would like, I can create a follow-on
> patch to remove that code.
I've added the above suggestions. If there is anything more you
can easily think of let me know.
next prev parent reply other threads:[~2021-03-30 17:04 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-26 5:58 start removing block bounce buffering support v2 Christoph Hellwig
2021-03-26 5:58 ` [PATCH 1/8] aha1542: use a local bounce buffer Christoph Hellwig
2021-03-29 6:22 ` Hannes Reinecke
2021-03-26 5:58 ` [PATCH 2/8] Buslogic: remove ISA support Christoph Hellwig
2021-03-29 6:22 ` Hannes Reinecke
2021-03-29 20:29 ` Khalid Aziz
2021-03-30 17:03 ` Christoph Hellwig [this message]
2021-03-30 17:15 ` Khalid Aziz
2021-03-30 17:31 ` Christoph Hellwig
2021-03-26 5:58 ` [PATCH 3/8] BusLogic: reject broken old firmware that requires ISA-style bounce buffering Christoph Hellwig
2021-03-29 6:23 ` Hannes Reinecke
2021-03-29 20:33 ` Khalid Aziz
2021-03-26 5:58 ` [PATCH 4/8] advansys: remove ISA support Christoph Hellwig
2021-03-29 6:31 ` Hannes Reinecke
2021-03-30 17:26 ` Christoph Hellwig
2021-03-26 5:58 ` [PATCH 5/8] scsi: remove the unchecked_isa_dma flag Christoph Hellwig
2021-03-29 6:31 ` Hannes Reinecke
2021-03-26 5:58 ` [PATCH 6/8] block: remove BLK_BOUNCE_ISA support Christoph Hellwig
2021-03-29 6:32 ` Hannes Reinecke
2021-03-26 5:58 ` [PATCH 7/8] block: refactor the bounce buffering code Christoph Hellwig
2021-03-29 6:34 ` Hannes Reinecke
2021-03-26 5:58 ` [PATCH 8/8] block: stop calling blk_queue_bounce for passthrough requests Christoph Hellwig
2021-03-29 6:37 ` Hannes Reinecke
2021-03-26 23:15 ` start removing block bounce buffering support v2 Jens Axboe
2021-03-30 3:08 ` Martin K. Petersen
-- strict thread matches above, loose matches on Subject: below --
2021-03-31 7:29 start removing block bounce buffering support v3 Christoph Hellwig
2021-03-31 7:29 ` [PATCH 2/8] Buslogic: remove ISA support Christoph Hellwig
2021-03-31 18:24 ` Khalid Aziz
2021-04-03 16:58 ` Maciej W. Rozycki
2021-04-06 6:27 ` Christoph Hellwig
2021-04-06 15:42 ` Maciej W. Rozycki
2021-04-12 12:26 ` Maciej W. Rozycki
2021-03-18 6:39 start removing block bounce buffering support Christoph Hellwig
2021-03-18 6:39 ` [PATCH 2/8] Buslogic: remove ISA support Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210330170320.GC13829@lst.de \
--to=hch@lst.de \
--cc=axboe@kernel.dk \
--cc=hare@suse.com \
--cc=khalid@gonehiking.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=linux@rainbow-software.org \
--cc=martin.petersen@oracle.com \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).