From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A782DC433ED for ; Thu, 1 Apr 2021 02:21:03 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8625161041 for ; Thu, 1 Apr 2021 02:21:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233143AbhDACUV (ORCPT ); Wed, 31 Mar 2021 22:20:21 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:42167 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233131AbhDACT4 (ORCPT ); Wed, 31 Mar 2021 22:19:56 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1617243596; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=ErDdkcFsJQKYgBqSgbmniSPhhhlVKC5FIXAEKrQICZ8=; b=P4re2lxQV4ziaZqiNK3vHnEnlp4aosnMUCAYLDHOO5qj8g7TfYTsDviZQNiZP/ZadVOVHU liRZ51DGF1ZF/Y+bbYjxAJBSawWE+5hxhSvlLkC0g7raWspZsODG9XdmfKoFcy4CZqppRz Z3S7oW2NZgHdI9W8SA3qpXAuPqm2foM= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-347-gERIIbICM3adaOPVFhDG7A-1; Wed, 31 Mar 2021 22:19:52 -0400 X-MC-Unique: gERIIbICM3adaOPVFhDG7A-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 45307801814; Thu, 1 Apr 2021 02:19:51 +0000 (UTC) Received: from localhost (ovpn-12-93.pek2.redhat.com [10.72.12.93]) by smtp.corp.redhat.com (Postfix) with ESMTP id 4EF5D5944D; Thu, 1 Apr 2021 02:19:40 +0000 (UTC) From: Ming Lei To: Jens Axboe Cc: linux-block@vger.kernel.org, Jeffle Xu , Mike Snitzer , dm-devel@redhat.com, Hannes Reinecke , Ming Lei Subject: [PATCH V5 00/12] block: support bio based io polling Date: Thu, 1 Apr 2021 10:19:15 +0800 Message-Id: <20210401021927.343727-1-ming.lei@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org Hi Jens, Add per-task io poll context for holding HIPRI blk-mq/underlying bios queued from bio based driver's io submission context, and reuse one bio padding field for storing 'cookie' returned from submit_bio() for these bios. Also explicitly end these bios in poll context by adding two new bio flags. In this way, we needn't to poll all underlying hw queues any more, which is implemented in Jeffle's patches. And we can just poll hw queues in which there is HIPRI IO queued. Usually io submission and io poll share same context, so the added io poll context data is just like one stack variable, and the cost for saving bios is cheap. V5: - fix one use-after-free issue in case that polling is from another context: adds one new cookie of BLK_QC_T_NOT_READY for preventing this issue in patch 8/12 - add reviewed-by & tested-by tag V4: - cover one more test_bit(QUEUE_FLAG_POLL, ...) suggested by Jeffle(01/12) - drop patch of 'block: add helper of blk_create_io_context' - add new helper of blk_create_io_poll_context() (03/12) - drain submission queues in exit_io_context(), suggested by Jeffle(08/13) - considering shared io context case for blk_bio_poll_io_drain() (08/13) - fix one issue in blk_bio_poll_pack_groups() as suggested by Jeffle(08/13) - add reviewed-by tag V3: - fix cookie returned for bio based driver, as suggested by Jeffle Xu - draining pending bios when submission context is exiting - patch style and comment fix, as suggested by Mike - allow poll context data to be NULL by always polling on submission queue - remove RFC, and reviewed-by V2: - address queue depth scalability issue reported by Jeffle via bio group list. Reuse .bi_end_io for linking bios which share same .bi_end_io, and support 32 such groups in submit queue. With this way, the scalability issue caused by kfifio is solved. Before really ending bio, .bi_end_io is recovered from the group head. Jeffle Xu (4): block/mq: extract one helper function polling hw queue block: add queue_to_disk() to get gendisk from request_queue block: add poll_capable method to support bio-based IO polling dm: support IO polling for bio-based dm device Ming Lei (8): block: add helper of blk_queue_poll block: add one helper to free io_context block: create io poll context for submission and poll task block: add req flag of REQ_POLL_CTX block: add new field into 'struct bvec_iter' block: prepare for supporting bio_list via other link block: use per-task poll context to implement bio based io polling blk-mq: limit hw queues to be polled in each blk_poll() block/bio.c | 5 + block/blk-core.c | 258 ++++++++++++++++++++++++++-- block/blk-ioc.c | 15 +- block/blk-mq.c | 308 +++++++++++++++++++++++++++++++++- block/blk-sysfs.c | 16 +- block/blk.h | 58 +++++++ drivers/md/dm-table.c | 24 +++ drivers/md/dm.c | 14 ++ drivers/nvme/host/core.c | 2 +- include/linux/bio.h | 132 ++++++++------- include/linux/blk_types.h | 30 +++- include/linux/blkdev.h | 4 + include/linux/bvec.h | 8 + include/linux/device-mapper.h | 1 + include/linux/iocontext.h | 2 + include/trace/events/kyber.h | 6 +- 16 files changed, 788 insertions(+), 95 deletions(-) -- 2.29.2