From: Christoph Hellwig <hch@infradead.org>
To: Md Haris Iqbal <haris.iqbal@ionos.com>
Cc: axboe@kernel.dk, linux-block@vger.kernel.org,
jinpu.wang@ionos.com, danil.kipnis@ionos.com,
Guoqing Jiang <guoqing.jiang@ionos.com>,
Johannes Thumshirn <johannes.thumshirn@wdc.com>,
Guoqing Jiang <jgq516@gmail.com>
Subject: Re: [PATCH V5 2/3] block: add a statistic table for io latency
Date: Thu, 8 Apr 2021 17:52:08 +0100 [thread overview]
Message-ID: <20210408165208.GA3944028@infradead.org> (raw)
In-Reply-To: <20210408135840.386076-3-haris.iqbal@ionos.com>
> +static ssize_t io_latency_show(struct device *dev, struct device_attribute *attr, char *buf)
> +{
> + struct block_device *bdev = dev_to_bdev(dev);
> + size_t count = 0;
> + int i, sgrp;
> +
> + for (i = 0; i < ADD_STAT_NUM; i++) {
> + unsigned int from, to;
> +
> + if (i == ADD_STAT_NUM - 1) {
> + count += scnprintf(buf + count, PAGE_SIZE - count, " >= %5d ms: ",
Please fix your overly long lines all over this code.
next prev parent reply other threads:[~2021-04-08 16:52 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-08 13:58 [PATCH V5 0/3] block: add two statistic tables Md Haris Iqbal
2021-04-08 13:58 ` [PATCH V5 1/3] block: add io_extra_stats node Md Haris Iqbal
2021-04-08 13:58 ` [PATCH V5 2/3] block: add a statistic table for io latency Md Haris Iqbal
2021-04-08 16:52 ` Christoph Hellwig [this message]
2021-04-08 17:06 ` Haris Iqbal
2021-04-08 13:58 ` [PATCH V5 3/3] block: add a statistic table for io sector Md Haris Iqbal
2021-04-08 22:22 ` [PATCH V5 0/3] block: add two statistic tables Khazhy Kumykov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210408165208.GA3944028@infradead.org \
--to=hch@infradead.org \
--cc=axboe@kernel.dk \
--cc=danil.kipnis@ionos.com \
--cc=guoqing.jiang@ionos.com \
--cc=haris.iqbal@ionos.com \
--cc=jgq516@gmail.com \
--cc=jinpu.wang@ionos.com \
--cc=johannes.thumshirn@wdc.com \
--cc=linux-block@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).