From: Christoph Hellwig <hch@infradead.org>
To: Ming Lei <ming.lei@redhat.com>
Cc: Christoph Hellwig <hch@infradead.org>,
Jens Axboe <axboe@kernel.dk>,
linux-block@vger.kernel.org,
Jeffle Xu <jefflexu@linux.alibaba.com>,
Mike Snitzer <snitzer@redhat.com>,
dm-devel@redhat.com, Hannes Reinecke <hare@suse.de>
Subject: Re: [PATCH V5 08/12] block: use per-task poll context to implement bio based io polling
Date: Mon, 12 Apr 2021 11:29:47 +0100 [thread overview]
Message-ID: <20210412102947.GA998763@infradead.org> (raw)
In-Reply-To: <YHQfB83n8dQSwD3O@T590>
On Mon, Apr 12, 2021 at 06:20:55PM +0800, Ming Lei wrote:
> > > +static inline void *bio_grp_data(struct bio *bio)
> > > +{
> > > + return bio->bi_poll;
> > > +}
> >
> > What is the purpose of this helper? And why does it have to lose the
> > type information?
>
> This patch stores bio->bi_end_io(shared with ->bi_poll) into one per-task
> data structure, and links all bios sharing same .bi_end_io into one list
> via ->bi_end_io. And their ->bi_end_io is recovered before calling
> bio_endio().
>
> The helper is used for checking if one bio can be added to bio group,
> and storing the data. The helper just serves for document purpose.
>
> And the type info doesn't matter.
So why is bi_poll typed to start with then just to need a accessor
to remove the typer information?
next prev parent reply other threads:[~2021-04-12 10:29 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-01 2:19 [PATCH V5 00/12] block: support bio based io polling Ming Lei
2021-04-01 2:19 ` [PATCH V5 01/12] block: add helper of blk_queue_poll Ming Lei
2021-04-01 2:19 ` [PATCH V5 02/12] block: add one helper to free io_context Ming Lei
2021-04-01 2:19 ` [PATCH V5 03/12] block: create io poll context for submission and poll task Ming Lei
2021-04-12 10:19 ` Christoph Hellwig
2021-04-01 2:19 ` [PATCH V5 04/12] block: add req flag of REQ_POLL_CTX Ming Lei
2021-04-01 2:19 ` [PATCH V5 05/12] block: add new field into 'struct bvec_iter' Ming Lei
2021-04-12 9:26 ` Christoph Hellwig
2021-04-13 9:36 ` Ming Lei
2021-04-01 2:19 ` [PATCH V5 06/12] block/mq: extract one helper function polling hw queue Ming Lei
2021-04-12 9:29 ` Christoph Hellwig
2021-04-01 2:19 ` [PATCH V5 07/12] block: prepare for supporting bio_list via other link Ming Lei
2021-04-12 10:18 ` Christoph Hellwig
2021-04-12 11:37 ` Ming Lei
2021-04-01 2:19 ` [PATCH V5 08/12] block: use per-task poll context to implement bio based io polling Ming Lei
2021-04-12 9:54 ` Christoph Hellwig
2021-04-12 10:20 ` Ming Lei
2021-04-12 10:29 ` Christoph Hellwig [this message]
2021-04-12 11:42 ` Ming Lei
2021-04-12 10:16 ` Christoph Hellwig
2021-04-12 10:37 ` Ming Lei
2021-04-01 2:19 ` [PATCH V5 09/12] blk-mq: limit hw queues to be polled in each blk_poll() Ming Lei
2021-04-01 2:19 ` [PATCH V5 10/12] block: add queue_to_disk() to get gendisk from request_queue Ming Lei
2021-04-12 12:52 ` Jens Axboe
2021-04-01 2:19 ` [PATCH V5 11/12] block: add poll_capable method to support bio-based IO polling Ming Lei
2021-04-12 9:38 ` Christoph Hellwig
2021-04-14 8:38 ` JeffleXu
2021-04-14 11:24 ` Ming Lei
2021-04-15 1:34 ` JeffleXu
2021-04-15 7:43 ` Ming Lei
2021-04-15 9:21 ` JeffleXu
2021-04-15 10:06 ` Ming Lei
2021-04-15 11:21 ` JeffleXu
2021-04-15 13:08 ` Ming Lei
2021-04-16 8:00 ` [PATCH] block: introduce QUEUE_FLAG_POLL_CAP flag Jeffle Xu
2021-04-16 8:42 ` JeffleXu
2021-04-16 9:07 ` Ming Lei
2021-04-16 10:20 ` JeffleXu
2021-04-17 14:06 ` JeffleXu
2021-04-19 2:21 ` Ming Lei
2021-04-19 5:40 ` JeffleXu
2021-04-19 13:36 ` Ming Lei
2021-04-20 7:25 ` JeffleXu
2021-04-01 2:19 ` [PATCH V5 12/12] dm: support IO polling for bio-based dm device Ming Lei
2021-04-09 15:39 ` [PATCH V5 00/12] block: support bio based io polling Ming Lei
2021-04-12 9:46 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210412102947.GA998763@infradead.org \
--to=hch@infradead.org \
--cc=axboe@kernel.dk \
--cc=dm-devel@redhat.com \
--cc=hare@suse.de \
--cc=jefflexu@linux.alibaba.com \
--cc=linux-block@vger.kernel.org \
--cc=ming.lei@redhat.com \
--cc=snitzer@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).