From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0FC6FC433ED for ; Mon, 19 Apr 2021 09:29:38 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id CA6AC6113C for ; Mon, 19 Apr 2021 09:29:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232004AbhDSJaG (ORCPT ); Mon, 19 Apr 2021 05:30:06 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35886 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231653AbhDSJaF (ORCPT ); Mon, 19 Apr 2021 05:30:05 -0400 Received: from casper.infradead.org (casper.infradead.org [IPv6:2001:8b0:10b:1236::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DC47BC06174A; Mon, 19 Apr 2021 02:29:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:To:From:Date:Sender:Reply-To:Cc: Content-Transfer-Encoding:Content-ID:Content-Description; bh=2aOsr0PrOwnfD3TDOKZ6BC+krPtm53sXeyFnBIAmB5o=; b=dlxuJSx74ojN6u2Cspw4sbyZBO 9m5osR+tXN1F9D2uMZozBeEkZ4MMcNCOPxCKoUyDXwaLoqiAm7VCtGRfluX5kw/ZtBzbxvpjFJBIV /Zof+qyjZPyk3+YUS+VqCwOMpgQNSaWNiBGx69mR7gC73d7qn1DGovpFArIHQp4g+ySK6sHCe/kO2 c0kem+FjGoDxzpGghmMe6FzIOZqhSZ/5ws/Gr5solihRG7qkAZF3RMNY/NrOey0EljxSkQUMLfdrT 65Nj+vMd0kqZDmygxvpE5HMY3SAXDAKkvrAq30rnObRAEEaMWzepVl2mvkN7IM1/snzMdSTlt1kI3 odEbSJGw==; Received: from hch by casper.infradead.org with local (Exim 4.94 #2 (Red Hat Linux)) id 1lYQD9-00DWee-NI; Mon, 19 Apr 2021 09:29:02 +0000 Date: Mon, 19 Apr 2021 10:28:55 +0100 From: Christoph Hellwig To: dsterba@suse.cz, Damien Le Moal , dm-devel@redhat.com, Mike Snitzer , linux-block@vger.kernel.org, Jens Axboe , linux-nvme@lists.infradead.org, Christoph Hellwig , linux-scsi@vger.kernel.org, "Martin K . Petersen" , linux-fsdevel@vger.kernel.org, linux-btrfs@vger.kernel.org, David Sterba , Josef Bacik , Johannes Thumshirn , Shinichiro Kawasaki , Naohiro Aota Subject: Re: [PATCH 3/4] btrfs: zoned: fail mount if the device does not support zone append Message-ID: <20210419092855.GA3223318@infradead.org> References: <20210416030528.757513-1-damien.lemoal@wdc.com> <20210416030528.757513-4-damien.lemoal@wdc.com> <20210416161720.GA7604@twin.jikos.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210416161720.GA7604@twin.jikos.cz> X-SRS-Rewrite: SMTP reverse-path rewritten from by casper.infradead.org. See http://www.infradead.org/rpr.html Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org On Fri, Apr 16, 2021 at 06:17:21PM +0200, David Sterba wrote: > On Fri, Apr 16, 2021 at 12:05:27PM +0900, Damien Le Moal wrote: > > From: Johannes Thumshirn > > > > For zoned btrfs, zone append is mandatory to write to a sequential write > > only zone, otherwise parallel writes to the same zone could result in > > unaligned write errors. > > > > If a zoned block device does not support zone append (e.g. a dm-crypt > > zoned device using a non-NULL IV cypher), fail to mount. > > > > Signed-off-by: Johannes Thumshirn > > Signed-off-by: Damien Le Moal > > Added to misc-next, thanks. I'll queue it for 5.13, it's not an urgent > fix for 5.12 release but i'll tag it as stable so it'll apear in 5.12.x > later. Please don't. Zone append is a strict requirement for zoned devices, no need to add cargo cult code like this everywhere.