From: "Michael S. Tsirkin" <mst@redhat.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: Enrico Granata <egranata@google.com>,
virtio-dev@lists.oasis-open.org, linux-block@vger.kernel.org,
virtualization@lists.linux-foundation.org
Subject: Re: [PATCH] Provide detailed specification of virtio-blk lifetime metrics
Date: Wed, 5 May 2021 16:10:56 -0400 [thread overview]
Message-ID: <20210505161022-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <20210505054314.GA4179527@infradead.org>
On Wed, May 05, 2021 at 06:43:14AM +0100, Christoph Hellwig wrote:
> On Tue, Apr 20, 2021 at 04:25:56PM +0000, Enrico Granata wrote:
> > In the course of review, some concerns were surfaced about the
> > original virtio-blk lifetime proposal, as it depends on the eMMC
> > spec which is not open
> >
> > Add a more detailed description of the meaning of the fields
> > added by that proposal to the virtio-blk specification, as to
> > make it feasible to understand and implement the new lifetime
> > metrics feature without needing to refer to JEDEC's specification
> >
> > This patch does not change the meaning of those fields nor add
> > any new fields, but it is intended to provide an open and more
> > clear description of the meaning associated with those fields.
> >
> > Signed-off-by: Enrico Granata <egranata@google.com>
>
> Still not a fan of the encoding, but at least it is properly documented
> now:
>
> Acked-by: Christoph Hellwig <hch@lst.de>
With that, would you like to ack the virtip-blk patch too?
The format didn't actually change ...
--
MST
next prev parent reply other threads:[~2021-05-05 20:11 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-20 16:25 [PATCH] Provide detailed specification of virtio-blk lifetime metrics Enrico Granata
2021-05-02 9:12 ` Michael S. Tsirkin
2021-05-05 10:34 ` Michael S. Tsirkin
2021-05-05 19:41 ` Enrico Granata
2021-05-05 5:43 ` Christoph Hellwig
2021-05-05 20:10 ` Michael S. Tsirkin [this message]
2021-05-05 21:01 ` [virtio-dev] " Enrico Granata
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210505161022-mutt-send-email-mst@kernel.org \
--to=mst@redhat.com \
--cc=egranata@google.com \
--cc=hch@infradead.org \
--cc=linux-block@vger.kernel.org \
--cc=virtio-dev@lists.oasis-open.org \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).