linux-block.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@lst.de>
To: song@kernel.org, axboe@kernel.dk
Cc: linux-raid@vger.kernel.org, linux-block@vger.kernel.org,
	"Florian D ." <spam02@dazinger.net>
Subject: [PATCH] md/raid5: remove an incorect assert in in_chunk_boundary
Date: Wed, 19 May 2021 08:22:15 +0200	[thread overview]
Message-ID: <20210519062215.4111256-1-hch@lst.de> (raw)

Now that the original bdev is stored in the bio this assert is incorrect
and will trigge for any partitioned raid5 device.

Reported-by:  Florian D. <spam02@dazinger.net>
Fixes: 309dca309fc3 ("block: store a block_device pointer in struct bio"),
Signed-off-by: Christoph Hellwig <hch@lst.de>
---
 drivers/md/raid5.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/md/raid5.c b/drivers/md/raid5.c
index 841e1c1aa5e6..7d4ff8a5c55e 100644
--- a/drivers/md/raid5.c
+++ b/drivers/md/raid5.c
@@ -5311,8 +5311,6 @@ static int in_chunk_boundary(struct mddev *mddev, struct bio *bio)
 	unsigned int chunk_sectors;
 	unsigned int bio_sectors = bio_sectors(bio);
 
-	WARN_ON_ONCE(bio->bi_bdev->bd_partno);
-
 	chunk_sectors = min(conf->chunk_sectors, conf->prev_chunk_sectors);
 	return  chunk_sectors >=
 		((sector & (chunk_sectors - 1)) + bio_sectors);
-- 
2.30.2


             reply	other threads:[~2021-05-19  6:22 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-19  6:22 Christoph Hellwig [this message]
2021-05-19  6:24 ` [PATCH] md/raid5: remove an incorect assert in in_chunk_boundary Christoph Hellwig
2021-05-19  7:57   ` Guoqing Jiang
2021-05-19 11:01 ` wp1083705-spam02 wp1083705-spam02
2021-05-24  4:38   ` Song Liu
2021-05-24 11:00     ` Florian D.
2021-05-26  1:05       ` Song Liu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210519062215.4111256-1-hch@lst.de \
    --to=hch@lst.de \
    --cc=axboe@kernel.dk \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-raid@vger.kernel.org \
    --cc=song@kernel.org \
    --cc=spam02@dazinger.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).