linux-block.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] init/Kconfig: Fix BLK_CGROUP help text indentation
@ 2021-05-16 14:57 Juerg Haefliger
  2021-05-17 10:36 ` Christoph Hellwig
  0 siblings, 1 reply; 3+ messages in thread
From: Juerg Haefliger @ 2021-05-16 14:57 UTC (permalink / raw)
  To: tj, axboe, cgroups, linux-block; +Cc: linux-kernel, Juerg Haefliger

The convention for help text indentation seems to be tab + 2 spaces.
Do that for BLK_CGROUP which currently only uses a single tab.

Signed-off-by: Juerg Haefliger <juergh@canonical.com>
---
 init/Kconfig | 33 +++++++++++++++++----------------
 1 file changed, 17 insertions(+), 16 deletions(-)

diff --git a/init/Kconfig b/init/Kconfig
index 9f1cde503739..5beaa0249071 100644
--- a/init/Kconfig
+++ b/init/Kconfig
@@ -926,22 +926,23 @@ config BLK_CGROUP
 	depends on BLOCK
 	default n
 	help
-	Generic block IO controller cgroup interface. This is the common
-	cgroup interface which should be used by various IO controlling
-	policies.
-
-	Currently, CFQ IO scheduler uses it to recognize task groups and
-	control disk bandwidth allocation (proportional time slice allocation)
-	to such task groups. It is also used by bio throttling logic in
-	block layer to implement upper limit in IO rates on a device.
-
-	This option only enables generic Block IO controller infrastructure.
-	One needs to also enable actual IO controlling logic/policy. For
-	enabling proportional weight division of disk bandwidth in CFQ, set
-	CONFIG_BFQ_GROUP_IOSCHED=y; for enabling throttling policy, set
-	CONFIG_BLK_DEV_THROTTLING=y.
-
-	See Documentation/admin-guide/cgroup-v1/blkio-controller.rst for more information.
+	  Generic block IO controller cgroup interface. This is the common
+	  cgroup interface which should be used by various IO controlling
+	  policies.
+
+	  Currently, CFQ IO scheduler uses it to recognize task groups and
+	  control disk bandwidth allocation (proportional time slice allocation)
+	  to such task groups. It is also used by bio throttling logic in
+	  block layer to implement upper limit in IO rates on a device.
+
+	  This option only enables generic Block IO controller infrastructure.
+	  One needs to also enable actual IO controlling logic/policy. For
+	  enabling proportional weight division of disk bandwidth in CFQ, set
+	  CONFIG_BFQ_GROUP_IOSCHED=y; for enabling throttling policy, set
+	  CONFIG_BLK_DEV_THROTTLING=y.
+
+	  See Documentation/admin-guide/cgroup-v1/blkio-controller.rst for more
+	  information.
 
 config CGROUP_WRITEBACK
 	bool
-- 
2.27.0


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] init/Kconfig: Fix BLK_CGROUP help text indentation
  2021-05-16 14:57 [PATCH] init/Kconfig: Fix BLK_CGROUP help text indentation Juerg Haefliger
@ 2021-05-17 10:36 ` Christoph Hellwig
  2021-05-19  8:34   ` Juerg Haefliger
  0 siblings, 1 reply; 3+ messages in thread
From: Christoph Hellwig @ 2021-05-17 10:36 UTC (permalink / raw)
  To: Juerg Haefliger
  Cc: tj, axboe, cgroups, linux-block, linux-kernel, Juerg Haefliger

While you're at it, please move the symbol to block/Kconfig.

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] init/Kconfig: Fix BLK_CGROUP help text indentation
  2021-05-17 10:36 ` Christoph Hellwig
@ 2021-05-19  8:34   ` Juerg Haefliger
  0 siblings, 0 replies; 3+ messages in thread
From: Juerg Haefliger @ 2021-05-19  8:34 UTC (permalink / raw)
  To: Christoph Hellwig
  Cc: Juerg Haefliger, tj, axboe, cgroups, linux-block, linux-kernel

[-- Attachment #1: Type: text/plain, Size: 167 bytes --]

On Mon, 17 May 2021 11:36:09 +0100
Christoph Hellwig <hch@infradead.org> wrote:

> While you're at it, please move the symbol to block/Kconfig.

Will send a v2.

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2021-05-19  8:34 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-05-16 14:57 [PATCH] init/Kconfig: Fix BLK_CGROUP help text indentation Juerg Haefliger
2021-05-17 10:36 ` Christoph Hellwig
2021-05-19  8:34   ` Juerg Haefliger

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).