From: Christoph Hellwig <hch@lst.de> To: Jens Axboe <axboe@kernel.dk> Cc: Thomas Bogendoerfer <tsbogend@alpha.franken.de>, Geoff Levand <geoff@infradead.org>, Ilya Dryomov <idryomov@gmail.com>, Dongsheng Yang <dongsheng.yang@easystack.cn>, Mike Snitzer <snitzer@redhat.com>, Ira Weiny <ira.weiny@intel.com>, dm-devel@redhat.com, linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org, linux-block@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, ceph-devel@vger.kernel.org Subject: [PATCH 10/16] block: remove bvec_kmap_irq and bvec_kunmap_irq Date: Tue, 8 Jun 2021 18:05:57 +0200 [thread overview] Message-ID: <20210608160603.1535935-11-hch@lst.de> (raw) In-Reply-To: <20210608160603.1535935-1-hch@lst.de> These two helpers are entirely unused now. Signed-off-by: Christoph Hellwig <hch@lst.de> --- include/linux/bio.h | 42 ------------------------------------------ 1 file changed, 42 deletions(-) diff --git a/include/linux/bio.h b/include/linux/bio.h index a0b4cfdf62a4..169b14b10c16 100644 --- a/include/linux/bio.h +++ b/include/linux/bio.h @@ -5,7 +5,6 @@ #ifndef __LINUX_BIO_H #define __LINUX_BIO_H -#include <linux/highmem.h> #include <linux/mempool.h> #include <linux/ioprio.h> /* struct bio, bio_vec and BIO_* flags are defined in blk_types.h */ @@ -523,47 +522,6 @@ static inline void bio_clone_blkg_association(struct bio *dst, struct bio *src) { } #endif /* CONFIG_BLK_CGROUP */ -#ifdef CONFIG_HIGHMEM -/* - * remember never ever reenable interrupts between a bvec_kmap_irq and - * bvec_kunmap_irq! - */ -static inline char *bvec_kmap_irq(struct bio_vec *bvec, unsigned long *flags) -{ - unsigned long addr; - - /* - * might not be a highmem page, but the preempt/irq count - * balancing is a lot nicer this way - */ - local_irq_save(*flags); - addr = (unsigned long) kmap_atomic(bvec->bv_page); - - BUG_ON(addr & ~PAGE_MASK); - - return (char *) addr + bvec->bv_offset; -} - -static inline void bvec_kunmap_irq(char *buffer, unsigned long *flags) -{ - unsigned long ptr = (unsigned long) buffer & PAGE_MASK; - - kunmap_atomic((void *) ptr); - local_irq_restore(*flags); -} - -#else -static inline char *bvec_kmap_irq(struct bio_vec *bvec, unsigned long *flags) -{ - return page_address(bvec->bv_page) + bvec->bv_offset; -} - -static inline void bvec_kunmap_irq(char *buffer, unsigned long *flags) -{ - *flags = 0; -} -#endif - /* * BIO list management for use by remapping drivers (e.g. DM or MD) and loop. * -- 2.30.2
next prev parent reply other threads:[~2021-06-08 16:07 UTC|newest] Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-06-08 16:05 switch the block layer to use kmap_local_page Christoph Hellwig 2021-06-08 16:05 ` [PATCH 01/16] mm: use kmap_local_page in memzero_page Christoph Hellwig 2021-06-08 18:17 ` Chaitanya Kulkarni 2021-06-08 16:05 ` [PATCH 02/16] MIPS: don't include <linux/genhd.h> in <asm/mach-rc32434/rb.h> Christoph Hellwig 2021-06-08 16:23 ` Bart Van Assche 2021-06-08 16:05 ` [PATCH 03/16] bvec: fix the include guards for bvec.h Christoph Hellwig 2021-06-08 16:23 ` Bart Van Assche 2021-06-08 18:18 ` Chaitanya Kulkarni 2021-06-08 16:05 ` [PATCH 04/16] bvec: add a bvec_kmap_local helper Christoph Hellwig 2021-06-08 18:18 ` Chaitanya Kulkarni 2021-06-09 9:33 ` Ilya Dryomov 2021-06-08 16:05 ` [PATCH 05/16] bvec: add memcpy_{from,to}_bvec and memzero_bvec helper Christoph Hellwig 2021-06-08 18:21 ` Chaitanya Kulkarni 2021-06-08 16:05 ` [PATCH 06/16] block: use memzero_page in zero_fill_bio Christoph Hellwig 2021-06-08 18:19 ` Chaitanya Kulkarni 2021-06-08 16:05 ` [PATCH 07/16] rbd: use memzero_bvec Christoph Hellwig 2021-06-09 9:37 ` Ilya Dryomov 2021-06-08 16:05 ` [PATCH 08/16] dm-writecache: use bvec_kmap_local instead of bvec_kmap_irq Christoph Hellwig 2021-06-08 16:30 ` Bart Van Assche 2021-06-08 16:38 ` Christoph Hellwig 2021-06-08 16:05 ` [PATCH 09/16] ps3disk: use memcpy_{from,to}_bvec Christoph Hellwig 2021-06-09 1:48 ` Ira Weiny 2021-06-11 6:53 ` Christoph Hellwig 2021-06-12 4:07 ` Ira Weiny 2021-06-15 5:02 ` Herbert Xu 2021-06-08 16:05 ` Christoph Hellwig [this message] 2021-06-08 16:05 ` [PATCH 11/16] block: rewrite bio_copy_data_iter to use bvec_kmap_local and memcpy_to_bvec Christoph Hellwig 2021-06-08 16:05 ` [PATCH 12/16] block: use memcpy_to_bvec in copy_to_high_bio_irq Christoph Hellwig 2021-06-08 18:24 ` Chaitanya Kulkarni 2021-06-08 16:06 ` [PATCH 13/16] block: use memcpy_from_bvec in bio_copy_kern_endio_read Christoph Hellwig 2021-06-08 18:26 ` Chaitanya Kulkarni 2021-06-08 16:06 ` [PATCH 14/16] block: use memcpy_from_bvec in __blk_queue_bounce Christoph Hellwig 2021-06-09 1:58 ` Ira Weiny 2021-06-08 16:06 ` [PATCH 15/16] block: use bvec_kmap_local in t10_pi_type1_{prepare,complete} Christoph Hellwig 2021-06-08 16:06 ` [PATCH 16/16] block: use bvec_kmap_local in bio_integrity_process Christoph Hellwig 2021-06-09 1:59 ` switch the block layer to use kmap_local_page Ira Weiny
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20210608160603.1535935-11-hch@lst.de \ --to=hch@lst.de \ --cc=axboe@kernel.dk \ --cc=ceph-devel@vger.kernel.org \ --cc=dm-devel@redhat.com \ --cc=dongsheng.yang@easystack.cn \ --cc=geoff@infradead.org \ --cc=idryomov@gmail.com \ --cc=ira.weiny@intel.com \ --cc=linux-block@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-mips@vger.kernel.org \ --cc=linuxppc-dev@lists.ozlabs.org \ --cc=snitzer@redhat.com \ --cc=tsbogend@alpha.franken.de \ --subject='Re: [PATCH 10/16] block: remove bvec_kmap_irq and bvec_kunmap_irq' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).