From: Satya Tangirala <firstname.lastname@example.org> To: Eric Biggers <email@example.com> Cc: Satya Tangirala <firstname.lastname@example.org>, email@example.com, firstname.lastname@example.org, Jens Axboe <email@example.com> Subject: Re: [PATCH v3 07/10] mmc: handle error from blk_ksm_register() Date: Thu, 24 Jun 2021 03:04:15 -0700 [thread overview] Message-ID: <20210624100415.GA4845@fractal> (raw) In-Reply-To: <YMrAn7EkKkNVEjUW@sol.localdomain> On Wed, Jun 16, 2021 at 08:25:19PM -0700, Eric Biggers wrote: > On Fri, Jun 04, 2021 at 07:58:57PM +0000, Satya Tangirala wrote: > > + /* > > + * This WARN_ON should never trigger since &host->ksm won't be > > + * "empty" (i.e. will support at least 1 crypto capability), an > > + * MMC device's request queue doesn't support integrity, and > > + * it also satisfies all the block layer constraints (i.e. > > + * supports SG gaps, doesn't have chunk sectors, has a > > + * sufficiently large supported max_segments per bio) > > + */ > > + WARN_ON(!blk_ksm_register(&host->ksm, q)); > > + } > > } > > There appear to be some MMC host drivers that set max_segments to 1, so this > explanation may not hold. It may hold for every driver that actually supports > crypto, though. Yeah, I think it does hold for every driver that actually supports crypto. I'll check this more carefully before sending out the next version. > > - Eric
next prev parent reply other threads:[~2021-06-24 10:04 UTC|newest] Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-06-04 19:58 [PATCH v3 00/10] ensure bios aren't split in middle of crypto data unit Satya Tangirala 2021-06-04 19:58 ` [PATCH v3 01/10] block: introduce blk_ksm_is_empty() Satya Tangirala 2021-06-16 23:47 ` Eric Biggers 2021-06-04 19:58 ` [PATCH v3 02/10] block: blk-crypto: introduce blk_crypto_bio_sectors_alignment() Satya Tangirala 2021-06-17 0:29 ` Eric Biggers 2021-06-04 19:58 ` [PATCH v3 03/10] block: introduce bio_required_sector_alignment() Satya Tangirala 2021-06-17 0:37 ` Eric Biggers 2021-06-04 19:58 ` [PATCH v3 04/10] block: respect bio_required_sector_alignment() in blk-crypto-fallback Satya Tangirala 2021-06-17 0:39 ` Eric Biggers 2021-06-17 4:34 ` Eric Biggers 2021-06-04 19:58 ` [PATCH v3 05/10] block: keyslot-manager: introduce blk_ksm_restrict_dus_to_queue_limits() Satya Tangirala 2021-06-17 1:58 ` Eric Biggers 2021-06-04 19:58 ` [PATCH v3 06/10] ufshcd: handle error from blk_ksm_register() Satya Tangirala 2021-06-04 19:58 ` [PATCH v3 07/10] mmc: " Satya Tangirala 2021-06-17 3:25 ` Eric Biggers 2021-06-24 10:04 ` Satya Tangirala [this message] 2021-06-04 19:58 ` [PATCH v3 08/10] dm: " Satya Tangirala 2021-06-17 3:23 ` Eric Biggers 2021-06-04 19:58 ` [PATCH v3 09/10] blk-merge: Ensure bios aren't split in middle of a crypto data unit Satya Tangirala 2021-06-04 19:59 ` [PATCH v3 10/10] block: add WARN_ON_ONCE() to bio_split() for sector alignment Satya Tangirala 2021-06-17 2:46 ` Eric Biggers 2021-06-17 3:51 ` [PATCH v3 00/10] ensure bios aren't split in middle of crypto data unit Eric Biggers
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20210624100415.GA4845@fractal \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --subject='Re: [PATCH v3 07/10] mmc: handle error from blk_ksm_register()' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).