From: Dan Carpenter <dan.carpenter@oracle.com>
To: kbuild@lists.01.org, mwilck@suse.com,
Mike Snitzer <snitzer@redhat.com>,
Alasdair G Kergon <agk@redhat.com>,
Bart Van Assche <Bart.VanAssche@sandisk.com>,
"Martin K. Petersen" <martin.petersen@oracle.com>,
linux-scsi@vger.kernel.org, dm-devel@redhat.com,
Hannes Reinecke <hare@suse.de>
Cc: lkp@intel.com, kbuild-all@lists.01.org,
Daniel Wagner <dwagner@suse.de>,
linux-block@vger.kernel.org, Paolo Bonzini <pbonzini@redhat.com>
Subject: [kbuild] Re: [PATCH v4 2/3] scsi: scsi_ioctl: add sg_io_to_blk_status()
Date: Tue, 29 Jun 2021 10:00:10 +0300 [thread overview]
Message-ID: <202106282356.dKNkiTUO-lkp@intel.com> (raw)
In-Reply-To: <20210628095210.26249-3-mwilck@suse.com>
Hi,
url: https://github.com/0day-ci/linux/commits/mwilck-suse-com/scsi-dm-dm_blk_ioctl-implement-failover-for-SG_IO-on-dm-multipath/20210628-175410
base: https://git.kernel.org/pub/scm/linux/kernel/git/mkp/scsi.git for-next
config: xtensa-randconfig-s032-20210628 (attached as .config)
compiler: xtensa-linux-gcc (GCC) 9.3.0
reproduce:
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# apt-get install sparse
# sparse version: v0.6.3-341-g8af24329-dirty
# https://github.com/0day-ci/linux/commit/259453ca972ae531cfdca07cbf4d6bb09b8f8c9f
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review mwilck-suse-com/scsi-dm-dm_blk_ioctl-implement-failover-for-SG_IO-on-dm-multipath/20210628-175410
git checkout 259453ca972ae531cfdca07cbf4d6bb09b8f8c9f
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' O=build_dir ARCH=xtensa SHELL=/bin/bash
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
sparse warnings: (new ones prefixed by >>)
>> block/scsi_ioctl.c:937:24: sparse: sparse: dubious: !x & y
vim +937 block/scsi_ioctl.c
259453ca972ae5 Martin Wilck 2021-06-28 932 blk_status_t sg_io_to_blk_status(struct sg_io_hdr *hdr)
259453ca972ae5 Martin Wilck 2021-06-28 933 {
259453ca972ae5 Martin Wilck 2021-06-28 934 int result;
259453ca972ae5 Martin Wilck 2021-06-28 935 blk_status_t sts;
259453ca972ae5 Martin Wilck 2021-06-28 936
259453ca972ae5 Martin Wilck 2021-06-28 @937 if (!hdr->info & SG_INFO_CHECK)
^
Should be if (!(hdr->info & SG_INFO_CHECK))
259453ca972ae5 Martin Wilck 2021-06-28 938 return BLK_STS_OK;
259453ca972ae5 Martin Wilck 2021-06-28 939
259453ca972ae5 Martin Wilck 2021-06-28 940 result = hdr->status |
259453ca972ae5 Martin Wilck 2021-06-28 941 (hdr->msg_status << 8) |
259453ca972ae5 Martin Wilck 2021-06-28 942 (hdr->host_status << 16) |
259453ca972ae5 Martin Wilck 2021-06-28 943 (hdr->driver_status << 24);
259453ca972ae5 Martin Wilck 2021-06-28 944
259453ca972ae5 Martin Wilck 2021-06-28 945 sts = __scsi_result_to_blk_status(&result, result);
259453ca972ae5 Martin Wilck 2021-06-28 946 hdr->host_status = host_byte(result);
259453ca972ae5 Martin Wilck 2021-06-28 947
259453ca972ae5 Martin Wilck 2021-06-28 948 return sts;
259453ca972ae5 Martin Wilck 2021-06-28 949 }
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
_______________________________________________
kbuild mailing list -- kbuild@lists.01.org
To unsubscribe send an email to kbuild-leave@lists.01.org
next prev parent reply other threads:[~2021-06-29 7:00 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-28 9:52 [PATCH v4 0/3] scsi/dm: dm_blk_ioctl(): implement failover for SG_IO on dm-multipath mwilck
2021-06-28 9:52 ` [PATCH v4 1/3] scsi: scsi_ioctl: export __scsi_result_to_blk_status() mwilck
2021-06-28 9:53 ` Christoph Hellwig
2021-06-28 14:57 ` Martin Wilck
2021-06-29 12:59 ` Christoph Hellwig
2021-06-29 19:23 ` Martin Wilck
2021-06-29 21:23 ` Keith Busch
2021-06-30 8:12 ` Martin Wilck
2021-06-30 16:01 ` Mike Snitzer
2021-06-30 16:54 ` Martin Wilck
2021-06-30 22:08 ` Bart Van Assche
2021-07-01 6:19 ` Christoph Hellwig
2021-07-06 16:40 ` Paolo Bonzini
2021-06-28 9:52 ` [PATCH v4 2/3] scsi: scsi_ioctl: add sg_io_to_blk_status() mwilck
2021-06-28 14:39 ` kernel test robot
2021-06-29 7:00 ` Dan Carpenter [this message]
2021-06-28 9:52 ` [PATCH v4 3/3] dm mpath: add CONFIG_DM_MULTIPATH_SG_IO - failover for SG_IO mwilck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202106282356.dKNkiTUO-lkp@intel.com \
--to=dan.carpenter@oracle.com \
--cc=Bart.VanAssche@sandisk.com \
--cc=agk@redhat.com \
--cc=dm-devel@redhat.com \
--cc=dwagner@suse.de \
--cc=hare@suse.de \
--cc=kbuild-all@lists.01.org \
--cc=kbuild@lists.01.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=lkp@intel.com \
--cc=martin.petersen@oracle.com \
--cc=mwilck@suse.com \
--cc=pbonzini@redhat.com \
--cc=snitzer@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).