linux-block.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] pd: fix order of cleaning up the queue and freeing the tagset
@ 2021-07-06  1:07 Guoqing Jiang
  2021-07-06  4:17 ` Christoph Hellwig
                   ` (2 more replies)
  0 siblings, 3 replies; 4+ messages in thread
From: Guoqing Jiang @ 2021-07-06  1:07 UTC (permalink / raw)
  To: axboe, tim, hch; +Cc: linux-block

From: Guoqing Jiang <jiangguoqing@kylinos.cn>

We must release the queue before freeing the tagset.

Fixes: 262d431f9000 ("pd: use blk_mq_alloc_disk and blk_cleanup_disk")
Signed-off-by: Guoqing Jiang <jiangguoqing@kylinos.cn>
---
 drivers/block/paride/pd.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/block/paride/pd.c b/drivers/block/paride/pd.c
index 3b2b8e872beb..9b3298926356 100644
--- a/drivers/block/paride/pd.c
+++ b/drivers/block/paride/pd.c
@@ -1014,8 +1014,8 @@ static void __exit pd_exit(void)
 		if (p) {
 			disk->gd = NULL;
 			del_gendisk(p);
-			blk_mq_free_tag_set(&disk->tag_set);
 			blk_cleanup_disk(p);
+			blk_mq_free_tag_set(&disk->tag_set);
 			pi_release(disk->pi);
 		}
 	}
-- 
2.25.1


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH] pd: fix order of cleaning up the queue and freeing the tagset
  2021-07-06  1:07 [PATCH] pd: fix order of cleaning up the queue and freeing the tagset Guoqing Jiang
@ 2021-07-06  4:17 ` Christoph Hellwig
  2021-07-15  6:58 ` Christoph Hellwig
  2021-07-15 15:29 ` Jens Axboe
  2 siblings, 0 replies; 4+ messages in thread
From: Christoph Hellwig @ 2021-07-06  4:17 UTC (permalink / raw)
  To: Guoqing Jiang; +Cc: axboe, tim, hch, linux-block

On Tue, Jul 06, 2021 at 09:07:34AM +0800, Guoqing Jiang wrote:
> From: Guoqing Jiang <jiangguoqing@kylinos.cn>
> 
> We must release the queue before freeing the tagset.
> 
> Fixes: 262d431f9000 ("pd: use blk_mq_alloc_disk and blk_cleanup_disk")
> Signed-off-by: Guoqing Jiang <jiangguoqing@kylinos.cn>

Looks good,

Reviewed-by: Christoph Hellwig <hch@lst.de>

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] pd: fix order of cleaning up the queue and freeing the tagset
  2021-07-06  1:07 [PATCH] pd: fix order of cleaning up the queue and freeing the tagset Guoqing Jiang
  2021-07-06  4:17 ` Christoph Hellwig
@ 2021-07-15  6:58 ` Christoph Hellwig
  2021-07-15 15:29 ` Jens Axboe
  2 siblings, 0 replies; 4+ messages in thread
From: Christoph Hellwig @ 2021-07-15  6:58 UTC (permalink / raw)
  To: axboe; +Cc: Guoqing Jiang, tim, linux-block

Jens, can you pick this one up?

On Tue, Jul 06, 2021 at 09:07:34AM +0800, Guoqing Jiang wrote:
> From: Guoqing Jiang <jiangguoqing@kylinos.cn>
> 
> We must release the queue before freeing the tagset.
> 
> Fixes: 262d431f9000 ("pd: use blk_mq_alloc_disk and blk_cleanup_disk")
> Signed-off-by: Guoqing Jiang <jiangguoqing@kylinos.cn>
> ---
>  drivers/block/paride/pd.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/block/paride/pd.c b/drivers/block/paride/pd.c
> index 3b2b8e872beb..9b3298926356 100644
> --- a/drivers/block/paride/pd.c
> +++ b/drivers/block/paride/pd.c
> @@ -1014,8 +1014,8 @@ static void __exit pd_exit(void)
>  		if (p) {
>  			disk->gd = NULL;
>  			del_gendisk(p);
> -			blk_mq_free_tag_set(&disk->tag_set);
>  			blk_cleanup_disk(p);
> +			blk_mq_free_tag_set(&disk->tag_set);
>  			pi_release(disk->pi);
>  		}
>  	}
> -- 
> 2.25.1
> 
---end quoted text---

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] pd: fix order of cleaning up the queue and freeing the tagset
  2021-07-06  1:07 [PATCH] pd: fix order of cleaning up the queue and freeing the tagset Guoqing Jiang
  2021-07-06  4:17 ` Christoph Hellwig
  2021-07-15  6:58 ` Christoph Hellwig
@ 2021-07-15 15:29 ` Jens Axboe
  2 siblings, 0 replies; 4+ messages in thread
From: Jens Axboe @ 2021-07-15 15:29 UTC (permalink / raw)
  To: Guoqing Jiang, tim, hch; +Cc: linux-block

On 7/5/21 7:07 PM, Guoqing Jiang wrote:
> From: Guoqing Jiang <jiangguoqing@kylinos.cn>
> 
> We must release the queue before freeing the tagset.

Applied, thanks.

-- 
Jens Axboe


^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2021-07-15 15:29 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-07-06  1:07 [PATCH] pd: fix order of cleaning up the queue and freeing the tagset Guoqing Jiang
2021-07-06  4:17 ` Christoph Hellwig
2021-07-15  6:58 ` Christoph Hellwig
2021-07-15 15:29 ` Jens Axboe

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).