archive mirror
 help / color / mirror / Atom feed
From: David Sterba <>
To: Naohiro Aota <>
	Jens Axboe <>, David Sterba <>
Subject: Re: [PATCH v3 3/3] btrfs: drop unnecessary ASSERT from btrfs_submit_direct()
Date: Wed, 21 Jul 2021 18:04:55 +0200	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

On Wed, Jul 21, 2021 at 09:43:34PM +0900, Naohiro Aota wrote:
> When on SINGLE block group, btrfs_get_io_geometry() will return "the
> size of the block group - the offset of the logical address within the
> block group" as geom.len. Since we allow up to 8 GB zone size on zoned
> btrfs, we can have up to 8 GB block group, so can have up to 8 GB
> geom.len. With this setup, we easily hit the "ASSERT(geom.len <=
> INT_MAX);".
> The ASSERT looks like to guard btrfs_bio_clone_partial() and bio_trim()
> which both take "int" (now "unsigned int" with the previous patch). So to

That is now u64, fixed in the case below too.

> be precise the ASSERT should check if clone_len <= UINT_MAX. But
> actually, clone_len is already capped by bio.bi_iter.bi_size which is
> unsigned int. So the ASSERT is not necessary.
> Drop the ASSERT and properly compare submit_len and geom.len in u64. Then,
> let the implicit casting to convert it to unsigned int.

As it's fixing the 8GB zone case I'd like to put the series to -rc
queue. There are the two block layer patches, reviewed by Christoph but
I'll wait a bit for acks before sending it to Linus. Meanwhile I'll add
it to for-next for testing. Thanks.

      reply	other threads:[~2021-07-21 16:07 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-21 12:43 [PATCH v3 0/3] fix argument type of bio_trim() Naohiro Aota
2021-07-21 12:43 ` [PATCH v3 1/3] block: fix arg " Naohiro Aota
2021-07-21 15:21   ` Christoph Hellwig
2021-07-21 12:43 ` [PATCH v3 2/3] btrfs: fix argument type of btrfs_bio_clone_partial() Naohiro Aota
2021-07-21 15:23   ` Christoph Hellwig
2021-07-21 12:43 ` [PATCH v3 3/3] btrfs: drop unnecessary ASSERT from btrfs_submit_direct() Naohiro Aota
2021-07-21 16:04   ` David Sterba [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).