From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BF027C6377D for ; Thu, 22 Jul 2021 13:05:28 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A24D1610CC for ; Thu, 22 Jul 2021 13:05:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231853AbhGVMYw (ORCPT ); Thu, 22 Jul 2021 08:24:52 -0400 Received: from verein.lst.de ([213.95.11.211]:34208 "EHLO verein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231738AbhGVMYw (ORCPT ); Thu, 22 Jul 2021 08:24:52 -0400 Received: by verein.lst.de (Postfix, from userid 2407) id 963DF68D06; Thu, 22 Jul 2021 15:05:25 +0200 (CEST) Date: Thu, 22 Jul 2021 15:05:25 +0200 From: Christoph Hellwig To: Ming Lei Cc: Jens Axboe , Christoph Hellwig , linux-block@vger.kernel.org, Thomas Gleixner , Greg Kroah-Hartman , John Garry , Sagi Grimberg , Daniel Wagner , Wen Xiong , Hannes Reinecke Subject: Re: [PATCH V6 1/3] genirq: add device_has_managed_msi_irq Message-ID: <20210722130525.GA26872@lst.de> References: <20210722095246.1240526-1-ming.lei@redhat.com> <20210722095246.1240526-2-ming.lei@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210722095246.1240526-2-ming.lei@redhat.com> User-Agent: Mutt/1.5.17 (2007-11-01) Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org On Thu, Jul 22, 2021 at 05:52:44PM +0800, Ming Lei wrote: > irq vector allocation with managed affinity may be used by driver, and > blk-mq needs this info for draining queue because genirq core will shutdown > managed irq when all CPUs in the affinity mask are offline. > > The info of using managed irq is often produced by drivers, and it is > consumed by blk-mq, so different subsystems are involved in this info flow. > > Address this issue by adding one helper of device_has_managed_msi_irq() > which is suggested by John Garry. This implies non-MSI irqs can't be managed, which is true right now. If the irq maintaines are fine with that: Reviewed-by: Christoph Hellwig